Iris/Eyre: websockets style and logic fixes#25
Merged
Conversation
polwex
approved these changes
Mar 11, 2026
Contributor
polwex
left a comment
polwex
left a comment
There was a problem hiding this comment.
LGTM, thank you, good catch on the path parsing.
bonbud-macryg
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily fixes style issues in Iris/Eyre for the Websockets PR.
Additionally, it restructures the scry in Iris so it doesn't skip security checks, and restructures the scry paths to be /ws/[app]/url/[url], etc, so that the desk in the beak is %$ in line with Eyre style, and so it doesn't depend on provenance which only works when requests come from agents.
It also fixes the URL parsing logic to use proper en-purl:html functions producing a (list @t) rather than a simple path parser that will get broken by query parameters and non-@ta characters in URL path elements. Note this means it pokes the handler app with a (list @t) rather than path for the URL, so the nostr agent will have to be changed to accommodate that. Without this change though, URL parsing will be unacceptably fragile.