-
Notifications
You must be signed in to change notification settings - Fork 375
Add ability to use plugin models #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ahnitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right.
|
@cdcapano Proposed change to your PR to fix the circular import issue cdcapano#5 |
|
I was having trouble with circular imports. Basic problem was custom model classes need to inherit from |
|
@ahnitz To avoid breaking backward compatibility, I decided to duck type the I'll add documentation and a tutorial in another PR. |
|
@cdcapano Ok, sounds good. |
* add ability to load plugin models * try to avoid circular imports * fix circular import by using functions to retrieve models * use get_models for building the models table * duck type models dict * code climate
This adds the ability for users to define their own models that can be used in pycbc inference, without needing to modify the source code. Borrows the same techniques as used for the plugin waveforms.