Improve documentation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gutentag2012
reviewed
Apr 7, 2024
docs/guide/what-are-signals.md
Outdated
| The Preact team has built a great solution and exposing their Signals API to the public and even created bindings for | ||
| Several frontend libraries use Signals as their state management solution, including [Svelte V5](https://svelte.dev/blog/runes), [SolidJS](https://www.solidjs.com/tutorial/introduction_signals), [Angular](https://angular.io/guide/signals), [Qwik](https://qwik.dev/docs/components/state/), [Preact](https://preactjs.com/guide/v10/signals/) | ||
| (and possibly many more). | ||
| Signals are not just a concept for; they can also be used in vanilla JavaScript code to create reactive values. |
There was a problem hiding this comment.
It feels like there is something missing in this scentence, probably you wanted to write something like this
Suggested change
| Signals are not just a concept for; they can also be used in vanilla JavaScript code to create reactive values. | |
| Signals are not just a concept of UI libraries; they can also be used in vanilla JavaScript code to create reactive values. |
There was a problem hiding this comment.
You're right. The sentence should have been:
"Signals are not just a concept used for UI libraries; they can also be used in vanilla JavaScript code to create reactive values."
I'll fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO