Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/form update options #11

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Fix/form update options #11

merged 4 commits into from
Apr 7, 2024

Conversation

gutentag2012
Copy link
Owner

Pull Request Template

Key Value
Status Done
Related Issues -
Description Fixing incorrect behaviour of form.updateSignals
Type of change Bug fix
Is a breaking change No

TODO

  • Own review of the code
  • All tests are passing
  • The code is well documented
  • The documentation website is up-to-date
  • Tests cover new code or fixes

Changes

When updating the options of a form, it was not possible to remove array items or dynamic object keys when passing new default values.
If there was an array with an item, the item would persist when passing an array without any items.

Copy link

github-actions bot commented Apr 7, 2024

Coverage Report for Form Core Coverage

Status Category Percentage Covered / Total
🔵 Lines 99.71% 694 / 696
🔵 Statements 99.72% 736 / 738
🔵 Functions 99.5% 199 / 200
🔵 Branches 99.75% 415 / 416
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/form-core/src/FormLogic.ts 100% 100% 100% 100%
Generated in workflow #45

Copy link

github-actions bot commented Apr 7, 2024

Coverage Report for Form React Coverage

Status Category Percentage Covered / Total
🔵 Lines 100% 68 / 68
🔵 Statements 100% 70 / 70
🔵 Functions 100% 29 / 29
🔵 Branches 100% 17 / 17
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/form-react/src/form/form.hooks.tsx 100% 100% 100% 100%
Generated in workflow #45

Copy link

github-actions bot commented Apr 7, 2024

Coverage Report for Validation Adapter Zod Coverage

Status Category Percentage Covered / Total
🔵 Lines 100% 16 / 16
🔵 Statements 100% 21 / 21
🔵 Functions 100% 7 / 7
🔵 Branches 100% 10 / 10
File CoverageNo changed files found.
Generated in workflow #45

@gutentag2012 gutentag2012 merged commit 1ba34f0 into main Apr 7, 2024
2 checks passed
@gutentag2012 gutentag2012 deleted the fix/form-update-options branch April 7, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant