ashikur2146 submission #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2024 06:12
implementation class name: CalculateAverage_ashikur2146 Execution time: 5 mins 34 seconds Device Specification: CPU: 11th Gen Intel(R) Core(TM) i5-1135G7 @2.40GHz Core: 8 RAM: 16 GB
… during data collection changes done from line number 30 to 38 Execution time: 4 mins 13 seconds Reference Execution time: 5 mins 34 seconds
Execution time: 3 mins 32 seconds Reference Execution time: 4 mins 13 seconds
|
Please run the formatter and amend the PR with the changes. |
|
I forgot to amend the commit [fbf6499] instead made a new commit after the formatter run. Meanwhile, there was another build failed happen due to missing license headers. I made the changes and ran the maven build with the following command, mvn clean verify formatter:format license:format it also works with ./mvnw clean verify. Please check now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation class name: CalculateAverage_ashikur2146 Execution time: 5 mins 34 seconds
Device Specification:
CPU: 11th Gen Intel(R) Core(TM) i5-1135G7 @2.40GHz
Core: 8
RAM: 16 GB
Check List:
./mvnw verifyand the project builds successfully./test.sh <username>shows no differences between expected and actual outputs)calculate_average_<username>.sh(make sure to match casing of your GH user name) and is executablecalculate_average_baseline.sh