Ensure that strings copied by strncpy() are NUL-terminated#28
Open
scfc wants to merge 1 commit intogumpu:releasefrom
Open
Ensure that strings copied by strncpy() are NUL-terminated#28scfc wants to merge 1 commit intogumpu:releasefrom
scfc wants to merge 1 commit intogumpu:releasefrom
Conversation
strncpy() does not guarantee that the destination buffer will be NUL-terminated, so this change ensures that by explicitly setting the last element to NUL. POSIX.1-2024 defines the function strlcpy() for that purpose, but given the standard's freshness and the limited number of occurrences in ROBODoc's source code, it was easier just to amend the few uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strncpy() does not guarantee that the destination buffer will be NUL-terminated, so this change ensures that by explicitly setting the last element to NUL.
POSIX.1-2024 defines the function strlcpy() for that purpose, but given the standard's freshness and the limited number of occurrences in ROBODoc's source code, it was easier just to amend the few uses.