fix feature importance local importance value computation

guillaume-vignal · Oct 24, 2024 · f7bfe57 · f7bfe57
1 parent 1693693
commit f7bfe57
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/shapash/explainer/smart_explainer.py b/shapash/explainer/smart_explainer.py
@@ -951,17 +951,17 @@ def compute_features_import(self, force=False, local=False):
             contributions=self.contributions, explain_data=self.explain_data, subset=None, norm=1
         )
 
+        if self.features_groups is not None and self.features_imp_groups is None:
+            self.features_imp_groups = self.state.compute_features_import(self.contributions_groups, norm=1)
+
         if local:
             self.features_imp_local_lev1 = self.backend.get_global_features_importance(
                 contributions=self.contributions, explain_data=self.explain_data, subset=None, norm=3
             )
             self.features_imp_local_lev2 = self.backend.get_global_features_importance(
                 contributions=self.contributions, explain_data=self.explain_data, subset=None, norm=7
             )
-
-        if self.features_groups is not None and self.features_imp_groups is None:
-            self.features_imp_groups = self.state.compute_features_import(self.contributions_groups, norm=1)
-            if local:
+            if self.features_groups is not None:
                 self.features_imp_groups_local_lev1 = self.state.compute_features_import(
                     self.contributions_groups, norm=3
                 )