Reintroduce subtitles file and use in looping video #14624 #14786
+121
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be removed before merge
… drawn by the browser. It instead draws another box around the cue box which is not desired.
…ubtitles are available to JS on all browsers.
…he cues by % off of that.
…ur cannot currently be modified whilst we only support the browser subtitle implementation.
…oundingClientRect
abeddow91
force-pushed
the
doml/subtitles
branch
from
66263d2 to
38bc8f7
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
changed the title
domlander
approved these changes
Nov 5, 2025
domlander
added
run_chromatic
|
Seen on PROD (merged by @abeddow91 7 minutes and 51 seconds ago) Please check your changes! |
abeddow91
added a commit
that referenced
this pull request
Nov 5, 2025
abeddow91
added a commit
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduces #14624 which was reverted whilst an hls chrome bug was investigated.