Skip to content

Make interactives support dark mode across platforms after June 2025 #14749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make interactives support dark mode across platforms after June 2025 #14749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dotcom-rendering/src/server/render.article.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,11 @@ window.twttr = (function(d, s, id) {
}(document, "script", "twitter-wjs"));
</script>`;

const { canonicalUrl } = frontendData;
const { canonicalUrl, webPublicationDate } = frontendData;

// Interactive dark mode support launched with full DCAR on June 25th 2025
const isBeforeInteractiveDarkModeSupportLaunch =
Date.parse(webPublicationDate) < Date.parse('2025-07-01T00:00:00Z');

const pageHtml = htmlPageTemplate({
linkedData,
Expand All @@ -189,7 +193,8 @@ window.twttr = (function(d, s, id) {
hasSurveyAd: !!frontendData.config.hasSurveyAd,
onlyLightColourScheme:
design === ArticleDesign.FullPageInteractive ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick question(s) for my understanding: are full page interactives not currently built with dark mode support? And is that a current limitation of the platform, or is it just not a design consideration at the moment?

design === ArticleDesign.Interactive,
(design === ArticleDesign.Interactive &&
isBeforeInteractiveDarkModeSupportLaunch),
});

return { html: pageHtml, prefetchScripts };
Expand Down
Loading