Merged
Conversation
wfsyre
requested changes
Apr 1, 2026
Collaborator
wfsyre
left a comment
wfsyre
left a comment
There was a problem hiding this comment.
No reviews on your most recent commit because its WIP
EthanMBoos
force-pushed
the
add-robust-logging-framework
branch
from
6777efc to
f3ce351
Compare
wfsyre
approved these changes
Apr 8, 2026
- Wrapped all stdout errors/warnings/info into logging macros. Maintained same stdout as before, now also write to scrimmage.log - Added try catch statements around typical error boundaries - Fixed step_loop timer bug
EthanMBoos
force-pushed
the
add-robust-logging-framework
branch
from
f3ce351 to
f14def4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going to add some unit tests to make sure it looks good, so stay posted.