fix: prevent false milestone-complete when unscaffolded phases remain#797
Open
ethan-hurst wants to merge 16 commits intogsd-build:mainfrom
Open
fix: prevent false milestone-complete when unscaffolded phases remain#797ethan-hurst wants to merge 16 commits intogsd-build:mainfrom
ethan-hurst wants to merge 16 commits intogsd-build:mainfrom
Conversation
added 15 commits
February 28, 2026 12:52
Adds /gsd:autopilot — one command to run the full pipeline (discuss → plan → execute → verify) for remaining phases automatically. New workflows: - auto-discuss.md: synthetic multi-agent discuss spawns 3/5/7/9 expert agents that debate gray areas and converge via majority consensus, producing CONTEXT.md without human Q&A - autopilot.md: thin loop orchestrator that ensures context exists then chains the existing auto-advance pipeline per phase New execution engine option: - Agent Teams mode (Claude Code only) as alternative to subagents - Graceful degradation to subagents when unavailable - Configurable teammate model (sonnet/opus/haiku) Config additions: - execution.engine: "subagents" (default) or "agent-teams" - execution.teammate_model: model for teammates - autopilot.discuss_agents: odd number 3-9 for consensus - autopilot.discuss_model: model for discuss agents - Validation enforces odd numbers and valid engine/model values Also updates settings.md (3 new questions), progress.md (autopilot in next-action suggestions), and execute-phase.md (engine routing + auto- chain verification).
Agent Teams can't set per-teammate models (teammates inherit lead's model), defeating GSD's profile-based model differentiation. Since wave-based plans are independent (no inter-agent communication needed), Agent Teams adds complexity with no benefit. - Remove execution.engine config key and validation - Rename teammate_model → agent_model across config, templates, workflows - Strip Agent Teams sections from execute-phase, auto-discuss, settings - Drop engine question from settings (9 → 8 settings)
execution.agent_model was configured and validated but never consumed by any workflow. Remove the entire execution config section — discuss model lives under autopilot.discuss_model where it's actually read.
Progress and phase-complete relied solely on disk directories to determine phase counts. When ROADMAP.md defined phases that had no directories yet, both code paths incorrectly reported the milestone as complete. Add getRoadmapPhaseNumbersInternal() to parse all phase numbers from ROADMAP.md. Use it in cmdInitProgress (new roadmap_phase_count field) and cmdPhaseComplete (ROADMAP fallback for next-phase detection). Fixes gsd-build#689, gsd-build#754, gsd-build#757, gsd-build#709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent progress and phase-complete from reporting milestone as complete when ROADMAP.md defines phases that have no disk directories yet.
Why
When all scaffolded phases were complete but ROADMAP still had unscaffolded phases,
cmdInitProgressreportedcompleted_count == phase_countandcmdPhaseCompletesetisLastPhase = true— both incorrectly triggering milestone-complete routing.Fixes #689, #754, #757, #709
Testing
Automated: All 168 existing tests pass (
node --test tests/core.test.cjs tests/init.test.cjs tests/phase.test.cjs)Manual:
gsd-tools init progressnow returnsroadmap_phase_count: 4vsphase_count: 1/completed_count: 1, correctly showing 3 unscaffolded phases remain.Checklist
Breaking Changes
None —
roadmap_phase_countis a new additive field; no existing fields changed.