DEV-519 Integerate drift detection with GitHub App #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Resonance1584 the action has moved to gruntwork-io |
Resonance1584
force-pushed
the
2024-09-11_drift
branch
from
f444a4a to
8985f36
Compare
Resonance1584
force-pushed
the
2024-09-11_drift
branch
from
8985f36 to
0c19faf
Compare
yhakbar
approved these changes
Sep 13, 2024
oredavids
reviewed
Sep 13, 2024
| JOB_NAME: ${{ env.JOB_NAME }} | ||
| STEP_NAME: "Execute Drift Detection" | ||
|
|
||
| consolidate_jobs: | ||
| runs-on: ${{ fromJSON(inputs.runner) }} | ||
| needs: pipelines_drift_detection | ||
| steps: | ||
| - name: Fetch Gruntwork Read Token | ||
| id: pipelines-gruntwork-read-token |
There was a problem hiding this comment.
Suggestion: consider removing "token" and or shortening the ids of these fetch steps( e.g fetch_read)
There was a problem hiding this comment.
It makes reading the later references easier on the eye
There was a problem hiding this comment.
Personally, I prefer it with the token suffix.
There was a problem hiding this comment.
I don't have a strong preference here, but currently these are consistent with the other workflow files. If this is a strong opinion we should update all of them at once in the v3 githubap branch. Leaving as is for now for consistency as it gets merged.
oredavids
approved these changes
Sep 13, 2024
Resonance1584
added a commit
that referenced
this pull request
Sep 17, 2024
* Use actions@2024-08-27_gruntcon_githubapp * Use [email protected] * Use pipelines-credentials for downloading actions * uses format * Update pipelines-root.yml * Fix correctly use outputs * typo * Try concatenate env * Try github var * Pass tokens to execute * Fix typo * debug cloning * chars * interp * less args * remove debugging * add new tokens to preflight * rename token * chore: baseline needs both tokens * chore: use the new tokens everywhere * chore: fix token thing * Fetch infra root write and org admin, pass to preflight * Switch out admin tokens in root * Disable provisioning temporarily * Fix read token ref * Update unlock to use github app tokens * Bump pipelines CLI to v0.29.0-rc2 * Use top level env GH_TOKEN * Use github app in delegated workflow * Bump pipelines CLI to v0.29.0-rc3 * Try rc3 * Try v0.28.2 * Trace log * v0.28.3-rc2 * v0.28.3-rc3 * v0.28.3-rc5 * v0.29.0-rc5 * fix: Set `api_base_url` * fix: Use `gruntwork-io` for `pipelines-credentials` * feat: Adding dynamicity to API URL * Use customer org token * DEV-519 Integerate drift detection with GitHub App (#86) * Integrate app * Add org read token * Add create pr token * Make secrets not required * Dynamic api_base_url * Use moved action --------- Co-authored-by: Zach Goldberg <[email protected]> Co-authored-by: Yousif Akbar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.