Improve toStdRegex output length benchmark
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3b7aab4.
Sorting union members automatically eliminates duplicates in unions.
That reduces expression size and in particluar avoids call-stack
overflows in the benchmark for instances with otherwise very deep
expression trees. However, overall expressions are even larger at
times and the sorting step also has a performance cost. Result on first
750 instances:
time : 4019 ms
avg. multiplier : 7
worst multiplier : 1247
Result on (almost) all 1000 benchmark instances:
time : 12037 ms
avg. multiplier : 17
worst multiplier : 1329
gruhn
force-pushed
the
improve-regex-length-bench
branch
from
fe60fdb to
e53dd16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.