Fix encoding of IPv6 scopes. #12564
Merged
Fix encoding of IPv6 scopes. #12564
+92
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add unit tests.
ejona86
approved these changes
Dec 16, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
In the future, include the component in the commit title. "api: Fix encoding of IPv6 scopes in Uri"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds unit tests and justification.
Both
java.net.Uriand Guava'sInetAddressespredate standardization of IPv6 scopes in URIs. They both emit/accept a naked % between the [square bracketed] address. This causes the current implementation to crash in io.grpc.Uri#getHost while percent decoding. RFC 6874 says that % in an IP-literal must be percent-encoded just as is done everywhere else.RFC 3986 & 9844 say not to support scopes at all but I think we should, for feature parity with
java.net.Uri.(Other contemporary libraries take the same approach, eg https://pkg.go.dev/net/url). A future PR will provide a first-class method to convert from
java.net.Urihandling all the edge cases.