Skip to content

Conversation

@seth-epps
Copy link

@seth-epps seth-epps commented Oct 24, 2025

Related to #8446

This follows up on the discussion here

By moving Labels and the associated Get/Set functions to the exported experimental/stats package we give client/server implementations of stats.Handler access to telemetry labels, otherwise only accessible if instrumented using an OpenTelemetry provider.

With this change, a handler implementation can start tracking telemetry labels by calling SetLabels in TagRPC/Tag Conn

RELEASE NOTES:

  • internal/stats: Move Labels to experimental/stats package

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 24, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: seth-epps / name: Seth Epps (ea3db1c)

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (58d4b2b) to head (ea3db1c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8671      +/-   ##
==========================================
+ Coverage   81.76%   83.02%   +1.25%     
==========================================
  Files         417      417              
  Lines       40806    32296    -8510     
==========================================
- Hits        33367    26815    -6552     
+ Misses       6057     4097    -1960     
- Partials     1382     1384       +2     
Files with missing lines Coverage Δ
experimental/stats/labels.go 100.00% <ø> (ø)
internal/stats/stats.go 100.00% <ø> (ø)
internal/xds/balancer/clusterimpl/picker.go 97.14% <100.00%> (+0.17%) ⬆️
stats/opentelemetry/client_metrics.go 88.11% <100.00%> (+1.44%) ⬆️

... and 359 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani added this to the 1.77 Release milestone Oct 24, 2025
@eshitachandwani eshitachandwani added Type: Internal Cleanup Refactors, etc Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability labels Oct 24, 2025
Copy link
Member

@eshitachandwani eshitachandwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Deferring to @easwars for another review.

@dfawley
Copy link
Member

dfawley commented Oct 24, 2025

I believe the decision to make these internal was made deliberately for cross-language parity reasons. So we might not want to do this without checking with the other languages first.

@eshitachandwani eshitachandwani dismissed their stale review October 27, 2025 05:40

Since we need a cross language discussion before making this change.

@eshitachandwani eshitachandwani self-assigned this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants