-
Couldn't load subscription status.
- Fork 4.6k
transport: Reduce heap allocations #8668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8668 +/- ##
=======================================
Coverage 81.97% 81.98%
=======================================
Files 417 417
Lines 40788 40804 +16
=======================================
+ Hits 33435 33452 +17
+ Misses 5991 5966 -25
- Partials 1362 1386 +24
🚀 New features to boost your workflow:
|
| last mem.Buffer // Stores the remaining data in the previous calls. | ||
| err error | ||
| _ noCopy | ||
| clientStream *ClientStream // The client transport stream is closed with the given error and nil trailer metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the given error does not make sense anymore. So, this comment needs to be updated.
| closeStream: func(err error) { | ||
| s.Close(err) | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What heap allocation does this reduce?
Benchmarks
RELEASE NOTES: N/A