-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: export MethodHandler #7794 #7796
Conversation
- Updated MethodHandler to be exportable for external use. - Modified MethodDesc struct to reference the exportable MethodHandler type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7796 +/- ##
==========================================
+ Coverage 81.71% 81.78% +0.07%
==========================================
Files 374 374
Lines 38166 38166
==========================================
+ Hits 31188 31215 +27
+ Misses 5699 5691 -8
+ Partials 1279 1260 -19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, adding @dfawley for second reviewer as he is part of the earlier discussion happened for the mentioned issue.
@mohdjishin please sign the CLA so we can merge this. |
signed @dfawley |
Made MethodHandler type exportable
Issue #7794
RELEASE NOTES:
MethodHandler
, which is the type of an already-exported field inMethodDesc