Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: export MethodHandler #7794 #7796

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

mohdjishin
Copy link
Contributor

@mohdjishin mohdjishin commented Oct 30, 2024

Made MethodHandler type exportable

  • Updated MethodHandler to be exportable for external use.
  • Modified MethodDesc struct to reference the exportable MethodHandler type.

Issue #7794

RELEASE NOTES:

  • grpc: export MethodHandler, which is the type of an already-exported field in MethodDesc

- Updated MethodHandler to be exportable for external use.
- Modified MethodDesc struct to reference the exportable MethodHandler type.
Copy link

linux-foundation-easycla bot commented Oct 30, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (d66fc3a) to head (668704d).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7796      +/-   ##
==========================================
+ Coverage   81.71%   81.78%   +0.07%     
==========================================
  Files         374      374              
  Lines       38166    38166              
==========================================
+ Hits        31188    31215      +27     
+ Misses       5699     5691       -8     
+ Partials     1279     1260      -19     
Files with missing lines Coverage Δ
server.go 82.00% <ø> (-0.08%) ⬇️

... and 21 files with indirect coverage changes

@aranjans aranjans added this to the 1.69 Release milestone Nov 5, 2024
@aranjans aranjans added Type: Behavior Change Behavior changes not categorized as bugs Area: Server Includes Server, Streams and Server Options. labels Nov 5, 2024
Copy link
Contributor

@aranjans aranjans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding @dfawley for second reviewer as he is part of the earlier discussion happened for the mentioned issue.

@dfawley dfawley added Type: Feature New features or improvements in behavior and removed Type: Behavior Change Behavior changes not categorized as bugs labels Nov 5, 2024
@dfawley dfawley assigned mohdjishin and unassigned dfawley Nov 5, 2024
@dfawley
Copy link
Member

dfawley commented Nov 5, 2024

@mohdjishin please sign the CLA so we can merge this.

@mohdjishin
Copy link
Contributor Author

@mohdjishin please sign the CLA so we can merge this.

signed @dfawley

@mohdjishin mohdjishin removed their assignment Nov 7, 2024
@arjan-bal arjan-bal changed the title Made MethodHandler type exportable #7794 grpc: export MethodHandler #7794 Nov 11, 2024
@arjan-bal arjan-bal merged commit 0d0e530 into grpc:master Nov 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Server Includes Server, Streams and Server Options. Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants