-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server interceptor acting as a middleware #762
base: master
Are you sure you want to change the base?
Conversation
Stream<R> intercept<Q, R>(ServiceCall call, ServiceMethod<Q, R> method, | ||
Stream<Q> requests, ServerStreamingInvoker<Q, R> invoker) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal here is to be close to the Client implementation. As the handler is a Stream, I did not add unary. It is probably doable tho.
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
File | Coverage |
---|---|
lib/grpc.dart | 💔 Not covered |
lib/src/server/handler.dart | 💚 96 % |
lib/src/server/interceptor.dart | 💚 100 % |
lib/src/server/server.dart | 💚 82 % ⬆️ 0 % |
lib/src/server/service.dart | 💚 97 % ⬆️ 1 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|---|
grpc | Any $1.Duration |
This check can be disabled by tagging the PR with skip-leaking-check
.
Should I do anything about the changelog health check? |
No, the breaking change should not be regarded as breaking and is from a different PR (note to self: the check should show that the breakage was introduced elsewhere..). The version is probably fine. I'll take a closer look at this once I get to it, quite busy ATM unfortunately. But thanks a lot already for the contribution! |
No worries, it can wait a bit 🙂 Just fyi, I'll be away from the 12th to end of march, so I won't be able to answer during this period. But I'll reply afterward. |
a317691
to
064818b
Compare
CI should pass now :) |
@mosuem Is the changelog failure something I can act on? |
Fix for #591
Example of usage:
I did not check if this PR solves #611, anyway if it does not it would probably be nice to open a second PR, this one is complex enough