Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

update suffix file method added #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barankaynak
Copy link
Contributor

In the receiver_policy method when should we run update method? An algorithm is required to determine when to update file.

@mpj17
Copy link
Member

mpj17 commented Mar 29, 2016

I love the intention @barankaynak but I have some questions.

  1. Is this the best module for this code?
  2. Is urllib the best choice? Using requests would be safer.
  3. Is rewriting the data shipped with the package a good idea?

Maybe it would be best to tackle the question you asked first? How about updating the list using a cron-job?

  • A script downloads the suffix-list to /tmp/gs-dmarc-suffixlist.txt
  • When determining the organisational domain receiver_policy looks up
    • The tmp-file first, and
    • Falls back to the suffix list shipped with the package.

@mpj17
Copy link
Member

mpj17 commented Mar 29, 2016

[Mostly for my own benefit]

It is possible to make a console_script depend on an extra.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants