-
Notifications
You must be signed in to change notification settings - Fork 1
One RTSP server, multiple streams #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ght/framegrab into tim/one-server-multiple-streams
…ght/framegrab into tim/one-server-multiple-streams
…ght/framegrab into tim/one-server-multiple-streams
@@ -0,0 +1,34 @@ | |||
FROM ubuntu:22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factoring out our system dependencies for CICD into this dockerfile seemed like a good idea, but I'm curious what others think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me since we have additional dependencies to install now. Good call!
[tool.poetry] | ||
name = "framegrab" | ||
version = "0.13.2" | ||
version = "0.14.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to RTSPServer are breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It would be great to update the README to include the new features but the implementation makes sense!
libgstreamer1.0-dev \ | ||
libgirepository1.0-dev \ | ||
gir1.2-gst-rtsp-server-1.0 \ | ||
gir1.2-gstreamer-1.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably include these in the README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the readme
@@ -0,0 +1,34 @@ | |||
FROM ubuntu:22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me since we have additional dependencies to install now. Good call!
A refactor of
RTSPServer
to allow for one server will multiple streams.Usage looks like this:
This also fixes a bug where the server only allowed one client per stream. Most of the complexity of this PR is due to special handling to allow multiple clients.
I also added a test for RTSP server/client functionality. This required a little refactor of our CICD setup.