Moved modules from Tasks to Tasks::Helpers

[vimutter]

We ran into the issue that our AR only app stopped running specs due to check that Rails is >6/7.
First quick fix was not possible because tasks.rb contained both code and code execution.

1. Moved module with methods to Helpers module. That way any adjustments on the logic could be done by:

require 'parallel_tests/tasks/helpers'
# monkey patch here 
require 'parallel_tests/tasks'

2. Changed Rails check to actual ActiveRecord check since that's what DB stuff is about. Here I am suggesting fixing our original issue.

[grosser]

to monkey-patch the existing setup you can create the module, prepend, and then require

can you split the move from the change (make a new PR with just 1 or the other) ... hard to review otherwise 😞

[vimutter]

Ah, never actually used prepend, thanks for the hint.

For whoever reading, here what is meant:

# Here we're in our patch code
module Patch
  def a
    print 'patched'
  end
end
module A
  class << self 
    prepend Patch
  end
end
# Patch code done, now we're loading original code
module A
  def self.a
    'not-patched'
  end
end
A.a # => 'patched'

Sure, will extract ActiveRecord change into separate PR.

[vimutter]

Added #987

Please let me know if this PR still needed. I think it does, keeping code definition away from code execution seems right.

[grosser]

afaik not needed, but also not against
... the code is not really executing when the require goes off, so 🤷

[grosser]

v4.9.0