Update runner.rb - A suggested fix for 'The command line is too long.' in Windows when the number of tests are huge #981
Conversation
A suggested fix for 'The command line is too long.' in Windows when the number of tests are huge
lib/parallel_tests/test/runner.rb
Outdated
| def process_in_batches(cmd, os_cmd_length_limit, tests) | ||
| # Filter elements not starting with value in tests to retain in each batch | ||
| # i.e. retain common parameters for each batch | ||
| retained_elements = cmd.reject { |s| s.start_with?(tests) } |
There was a problem hiding this comment.
isn't tests files[:first] so just a file and not a prefix ?
There was a problem hiding this comment.
when we start the process we give features/ and files[:first] has that .. which has been expanded into individual files into cmd array
There was a problem hiding this comment.
ahh ... yeah that's a bit brittle, user could be giving multiple folders too ... I'll see if I can find a better way, otherwise keeping with a comment
There was a problem hiding this comment.
won't work with minitest since that uses requires and not a list of files
"%w[#{require_list}].each { |f| require %{./\#{f}} }",
Co-authored-by: Michael Grosser <[email protected]>
Co-authored-by: Michael Grosser <[email protected]>
Co-authored-by: Michael Grosser <[email protected]>
|
I'll make a new PR with some more changes + tests |
| @@ -99,7 +134,24 @@ def execute_command(cmd, process_number, num_processes, options) | |||
|
|
|||
| print_command(cmd, env) if report_process_command?(options) && !options[:serialize_stdout] | |||
|
|
|||
| execute_command_and_capture_output(env, cmd, options) | |||
| result = [] | |||
| process_in_batches(cmd, 8191, options[:files].first).map do |subcmd| | |||
There was a problem hiding this comment.
I don't get the options[:files].first) part, why is the first file the suffix for all other files ?
(tested with start_with? in process_in_batches)
There was a problem hiding this comment.
... I'd split the commands at the first file
There was a problem hiding this comment.
the common parameters can appear after the files as well .. hence i was doing a starts_with ..
There was a problem hiding this comment.
thx, updated in my draft, plz see if that looks alright
|
lmk if #982 looks good then I'll add some tests |
|
tried a new approach #984 |
A suggested fix for 'The command line is too long.' in Windows when the number of tests are huge
Thank you for your contribution!
Checklist
master(if not - rebase it).code introduces user-observable changes.