Adds an error message bag for connection issues with LDAP #17894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godmartinz
changed the title
Godmartinz
changed the title
|
@uberbrady this works, but having a hard time dealing with the type error on $connection. Might need to pick your brain on this one. |
|
I'm not actually sure what you mean by trying to login with tailwind active? We don't use tailwind. Also (more importantly) we wouldn't want to convey that the LDAP server cannot be reached, since that would tell an attacker that the login uses LDAP in the first place, which is information we don't want to disclose. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried logging in without tailwind active and I received a timeout error. This adds some error message handling for that and a couple other things.
No Code, cant connect:
Wrong username (49):