Updated to include other data sources in QR codes

[swift2512]

Asset ID, Asset Tag and Serial number are already defined in 'app/View/Label.php' so users should be able to select it for their QR codes. Generated barcodes scan as intended.

app/View/Label.php

[snipe]

Hi - can you rebase this? I see a ton of commits in here that are mine, not yours, which makes it really hard to see what you actually did.

[snipe]

Hi again - PRs should always be put up against the develop branch, not master, per the dev documentation.

[swift2512]

Hi - can you rebase this? I see a ton of commits in here that are mine, not yours, which makes it really hard to see what you actually did.

I am really bad with GIT. Basically, I have no clue when it comes to pull requests. 🤣

[uberbrady]

I get it - and git is a very powerful tool, but also, very very unintuitive, so it can be a real beast.

There are two ways we can go on this - on the first hand, we can try to walk you through how to do this on your own, via git. Or, on the other hand, we can just do it for you. Since you've been a power-user for a while, and might want to make more contributions in the future, Option 1 is probably the best choice for the long-term. But I would totally understand option two.

If you did want to try and do this yourself, this is what you'd do.

1. Fork our repo onto your own personal namespace. It looks like you've already done this, either on purpose or inadvertently - but here it is: https://github.com/swift2512/snipe-it
2. Get your branch caught up to date by clicking the 'Sync fork' button on Github.
3. Follow the instructions from the green 'code' button to get that repo onto your computer
4. try git checkout patch-4 to make sure you have your patch. Also do a git pull
5. Switch to develop (git checkout develop). Do a git pull to make sure you're brought up to date with the latest.
6. Create a new branch from develop to put your changes onto - git checkout -b patch-4-cleaned (or something like that).
7. Now, what we want to do is cherry-pick the changes you've made, onto this branch. git cherry-pick e07572684a28fedb10fcc00aaf59acd4266864f3..c443acc6c5870357dc9c509d230daf93781d92af (those are the two commit-hashes for your two changes).
8. git commit
9. git push or maybe git push -u origin patch-4-cleaned (or whatever you named your branch).
10. Go back to the Github interface on the Snipe-IT repo and create your PR from there. Make sure to pick 'develop' as your source branch.

Honestly, just writing up the instructions was pretty horrible! I do hate that this tooling can be so genuinely unpleasant to use sometimes - but I guess that's just life :/

And it really would be no bother if you want to just ask us to do it - I just wanted to make sure you could start to learn some of this stuff if you were interested.

GitHub

GitHub - swift2512/snipe-it: A free open source IT asset/license management system

A free open source IT asset/license management system - swift2512/snipe-it

[swift2512]

@uberbrady I've tried and failed miserably 😅 Commit got lost somewhere without branch. Created a new pull request. Could you point it to the right direction? I really love that QR codes point to Asset ID name - makes my barcode scanner useful.
#18020