Skip to content

Conversation

carojeandat
Copy link
Contributor

No description provided.

@EstherDarkish EstherDarkish self-requested a review October 7, 2025 07:07
@SlimaneAmar
Copy link
Contributor

No need to use Redux
Remove it !

console.info(event.data);
isInitiatingCopyTab.current = false;
if (JSON.stringify(emptyCopiedModificationsSelection) === JSON.stringify(event.data)) {
setCopiedModifications((oldCopiedModifications) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this code !

const broadcast = new BroadcastChannel('modificationsCopyChannel');
broadcast.onmessage = (event) => {
console.info('message received from broadcast channel');
console.info(event.data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concatenate logs !


"CopiedNodeInvalidationMessage": "Suite à modification de nœud, le contenu du presse papier a été supprimé",
"CopiedModificationInvalidationMessage": "Suite à modification d'hypothèse, le contenu du presse papier a été supprimé",
"CopiedModificationInvalidationMessageFromAnotherStudy": "Suite à la modification d'un hypothèse dans l'étude d'origine des modifications copiées, le contenu du presse papier a été supprimé",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo une


"CopiedNodeInvalidationMessage": "Suite à modification de nœud, le contenu du presse papier a été supprimé",
"CopiedModificationInvalidationMessage": "Suite à modification d'hypothèse, le contenu du presse papier a été supprimé",
"CopiedModificationInvalidationMessageFromAnotherStudy": "Suite à la modification d'un hypothèse dans l'étude d'origine des modifications copiées, le contenu du presse papier a été supprimé",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use this term hypothèse !

Copy link
Contributor

@EstherDarkish EstherDarkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK Test OK Console warning check OK

Copy link

@carojeandat carojeandat merged commit 9cd9848 into main Oct 13, 2025
5 checks passed
@carojeandat carojeandat deleted the copy-paste-network-modifications branch October 13, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants