-
Notifications
You must be signed in to change notification settings - Fork 4
Copy paste network modifications from different studies #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No need to use Redux |
src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
Outdated
Show resolved
Hide resolved
src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
Outdated
Show resolved
Hide resolved
src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
Show resolved
Hide resolved
src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
Outdated
Show resolved
Hide resolved
console.info(event.data); | ||
isInitiatingCopyTab.current = false; | ||
if (JSON.stringify(emptyCopiedModificationsSelection) === JSON.stringify(event.data)) { | ||
setCopiedModifications((oldCopiedModifications) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this code !
const broadcast = new BroadcastChannel('modificationsCopyChannel'); | ||
broadcast.onmessage = (event) => { | ||
console.info('message received from broadcast channel'); | ||
console.info(event.data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concatenate logs !
src/translations/fr.json
Outdated
|
||
"CopiedNodeInvalidationMessage": "Suite à modification de nœud, le contenu du presse papier a été supprimé", | ||
"CopiedModificationInvalidationMessage": "Suite à modification d'hypothèse, le contenu du presse papier a été supprimé", | ||
"CopiedModificationInvalidationMessageFromAnotherStudy": "Suite à la modification d'un hypothèse dans l'étude d'origine des modifications copiées, le contenu du presse papier a été supprimé", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo une
src/translations/fr.json
Outdated
|
||
"CopiedNodeInvalidationMessage": "Suite à modification de nœud, le contenu du presse papier a été supprimé", | ||
"CopiedModificationInvalidationMessage": "Suite à modification d'hypothèse, le contenu du presse papier a été supprimé", | ||
"CopiedModificationInvalidationMessageFromAnotherStudy": "Suite à la modification d'un hypothèse dans l'étude d'origine des modifications copiées, le contenu du presse papier a été supprimé", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use this term hypothèse
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK Test OK Console warning check OK
|
No description provided.