Add filter by substation or VL to contingency list #741

flomillot · 2025-10-10T16:59:58Z

Introduced support for sub-equipment management in filter-based contingency lists.
Added FilterBasedContingencyListVisualizationPanel for enhanced data visualization and management.
Extended data schemas, form handling, and UI interactions to accommodate new sub-equipment feature.

To fix :

empty space at right of the Dialog
responsive height on the whole Dialog, ie tables at the same level, scroll bar on tables \ dialog when adding description or lot of filters...

- Introduced support for sub-equipment management in filter-based contingency lists. - Added `FilterBasedContingencyListVisualizationPanel` for enhanced data visualization and management. - Extended data schemas, form handling, and UI interactions to accommodate new sub-equipment feature. Signed-off-by: Florent MILLOT <[email protected]>

EtienneLt · 2025-10-13T09:21:39Z

/home/lesoteti/Projects/Gridsuite/gridexplore-app/src/components/dialogs/contingency-list/filter-based/FilterBasedContingencyListVisualizationPanel.tsx
22:18 warning Insert , prettier/prettier

EtienneLt

minor things

src/translations/fr.json

…sh and French Signed-off-by: Florent MILLOT <[email protected]>

…elProps` as `Readonly` Signed-off-by: Florent MILLOT <[email protected]>

src/utils/rest-api.ts

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx

…ters and type usage improvements Signed-off-by: Florent MILLOT <[email protected]>

basseche · 2025-10-14T15:07:45Z

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-dialog.tsx

-            unscrollableFullHeight
            disabledSave={Boolean(!!nameError || isValidating)}
            isDataFetching={isFetching}
+            sx={{


height are width are not correct. Height should be 90vh and width: 50vw.
if not possible keep unscrollableFullHeight and we'll try to fix it in another PR

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-form.tsx

basseche · 2025-10-14T15:19:28Z

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-form.tsx

+                        </Grid>
+                        <Grid item xs={6}>
+                            <TableContainer component={Paper} sx={{ height: '100%', border: 0.5 }}>
+                                <Table>


I think you can reduce lineHeight by using size="small"

…e and fix casing for file import paths Signed-off-by: Florent MILLOT <[email protected]>

…fic types in contingency list filters Signed-off-by: Florent MILLOT <[email protected]>

… and consistency. Signed-off-by: Florent MILLOT <[email protected]>

…zationPanel` - Renamed `id` to `filterId` in `selectedEquipmentTypesByFilter` for better readability. - Adjusted grid layout properties and added padding for improved UI alignment. - Refactored variable names and method calls for enhanced code clarity. Signed-off-by: Florent MILLOT <[email protected]>

…sistency in `ContingencyListUtils`. Signed-off-by: Florent MILLOT <[email protected]>

- Added full-height styling to `Grid` in `ContingencyListFilterBasedForm`. - Set dialog height to 95% of viewport in `ContingencyListFilterBasedDialog`. Signed-off-by: Florent MILLOT <[email protected]>

- Adjusted `Grid` styling with a minimum width to address layout issues. Signed-off-by: Florent MILLOT <[email protected]>

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-dialog.tsx

…ent layout Signed-off-by: Florent MILLOT <[email protected]>

…VisualizationPanel` - Updated condition to include `isFetching` check. Signed-off-by: Florent MILLOT <[email protected]>

- Removed redundant `xs` properties and adjusted `Grid` structure to simplify layout and maintain consistency. Signed-off-by: Florent MILLOT <[email protected]>

- Consolidated `loadingOverlayComponent` and `loadingOverlayComponentParams` into a single `overlay` object. - Simplified and clarified conditional logic for `shouldDisplayRefreshButton`. Signed-off-by: Florent MILLOT <[email protected]>

…stVisualizationPanel` - Display a warning alert if study data has missing equipments. - Update translations to include `missingEquipmentsFromStudy` entries in English and French. Signed-off-by: Florent MILLOT <[email protected]>

…alignment Signed-off-by: Florent MILLOT <[email protected]>

… alignment. Signed-off-by: Florent MILLOT <[email protected]>

thangqp · 2025-10-15T16:33:09Z

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx

+    resizable: false,
+    sortable: false,
+};
+


Suggested change

export function RefreshOverlay({ loading, ...buttonProps }: Readonly<{ loading: boolean } & ButtonProps>) {

return loading ? <CircularProgress /> : <RefreshButton {...buttonProps} />;

}

thangqp · 2025-10-15T16:33:42Z

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx

+
+    const overlay = shouldDisplayRefreshButton
+        ? {
+              loadingOverlayComponent: RefreshButton,


Suggested change

loadingOverlayComponent: RefreshButton,

loadingOverlayComponent: RefreshOverlay,

thangqp · 2025-10-15T16:34:42Z

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx

+              loadingOverlayComponentParams: { disabled: true }, // disable the button when loading
+              // rendering another loadingOverlayComponent or overlayLoadingTemplate does not work


Suggested change

loadingOverlayComponentParams: { disabled: true }, // disable the button when loading

// rendering another loadingOverlayComponent or overlayLoadingTemplate does not work

loadingOverlayComponentParams: { loading: true },

flomillot requested a review from basseche October 10, 2025 16:59

Merge branch 'main' into filter-based-contingency-list

f3da51a

EtienneLt reviewed Oct 13, 2025

View reviewed changes

src/translations/fr.json Outdated Show resolved Hide resolved

src/translations/fr.json Outdated Show resolved Hide resolved

flomillot added 2 commits October 13, 2025 15:46

Update translations for contingency list table column labels in Engli…

65e8221

…sh and French Signed-off-by: Florent MILLOT <[email protected]>

Replace crypto import with node:crypto and mark `VisualizationPan…

ce12ae9

…elProps` as `Readonly` Signed-off-by: Florent MILLOT <[email protected]>

thangqp reviewed Oct 13, 2025

View reviewed changes

src/utils/rest-api.ts Outdated Show resolved Hide resolved

thangqp reviewed Oct 14, 2025

View reviewed changes

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx Show resolved Hide resolved

Refactor contingency list filter-related functions to simplify parame…

aed876d

…ters and type usage improvements Signed-off-by: Florent MILLOT <[email protected]>

basseche reviewed Oct 14, 2025

View reviewed changes

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-form.tsx Outdated Show resolved Hide resolved

basseche reviewed Oct 14, 2025

View reviewed changes

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-form.tsx Outdated Show resolved Hide resolved

basseche reviewed Oct 14, 2025

View reviewed changes

flomillot and others added 7 commits October 14, 2025 17:32

Adapt contingency list filters to use FiltersWithEquipmentTypes typ…

960d90f

…e and fix casing for file import paths Signed-off-by: Florent MILLOT <[email protected]>

Cast values returned by useWatch to unknown before applying speci…

002d49b

…fic types in contingency list filters Signed-off-by: Florent MILLOT <[email protected]>

Rename id to filterId in FilterBasedContingencyList for clarity…

87287ef

… and consistency. Signed-off-by: Florent MILLOT <[email protected]>

Rename id to filterId in selectedEquipmentTypesByFilter for con…

df1ed00

…sistency in `ContingencyListUtils`. Signed-off-by: Florent MILLOT <[email protected]>

Adjust grid and dialog layout for improved UI responsiveness

05e2e88

- Added full-height styling to `Grid` in `ContingencyListFilterBasedForm`. - Set dialog height to 95% of viewport in `ContingencyListFilterBasedDialog`. Signed-off-by: Florent MILLOT <[email protected]>

Fix grid layout in FilterBasedContingencyListVisualizationPanel

3c0f304

- Adjusted `Grid` styling with a minimum width to address layout issues. Signed-off-by: Florent MILLOT <[email protected]>

thangqp reviewed Oct 15, 2025

View reviewed changes

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx Outdated Show resolved Hide resolved

thangqp reviewed Oct 15, 2025

View reviewed changes

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx Outdated Show resolved Hide resolved

thangqp reviewed Oct 15, 2025

View reviewed changes

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx Outdated Show resolved Hide resolved

thangqp reviewed Oct 15, 2025

View reviewed changes

.../dialogs/contingency-list/filter-based/filter-based-contingency-list-visualization-panel.tsx Show resolved Hide resolved

thangqp reviewed Oct 15, 2025

View reviewed changes

src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-dialog.tsx Show resolved Hide resolved

flomillot added 4 commits October 15, 2025 14:53

Adjust grid container in ContingencyListFilterBasedForm for consist…

961aafc

…ent layout Signed-off-by: Florent MILLOT <[email protected]>

Fix shouldDisplayRefreshButton logic in `FilterBasedContingencyList…

7dfb84d

…VisualizationPanel` - Updated condition to include `isFetching` check. Signed-off-by: Florent MILLOT <[email protected]>

Fix grid layout in FilterBasedContingencyListVisualizationPanel

353545d

- Removed redundant `xs` properties and adjusted `Grid` structure to simplify layout and maintain consistency. Signed-off-by: Florent MILLOT <[email protected]>

Fix grid layout in FilterBasedContingencyListVisualizationPanel

90545ad

- Removed redundant `xs` properties and adjusted `Grid` structure to simplify layout and maintain consistency. Signed-off-by: Florent MILLOT <[email protected]>

flomillot added 4 commits October 15, 2025 16:49

Adjust grid margins in ContingencyListFilterBasedForm for improved …

c04a50f

…alignment Signed-off-by: Florent MILLOT <[email protected]>

Fine-tune grid margins in ContingencyListFilterBasedForm for better…

cf1d7ef

… alignment. Signed-off-by: Florent MILLOT <[email protected]>

thangqp reviewed Oct 15, 2025

View reviewed changes

+export function RefreshOverlay({ loading, ...buttonProps }: Readonly<{ loading: boolean } & ButtonProps>) {
+    return loading ? <CircularProgress /> : <RefreshButton {...buttonProps} />;
+}

	loadingOverlayComponent: RefreshButton,
	loadingOverlayComponent: RefreshOverlay,

		loadingOverlayComponentParams: { disabled: true }, // disable the button when loading
		// rendering another loadingOverlayComponent or overlayLoadingTemplate does not work

	loadingOverlayComponentParams: { disabled: true }, // disable the button when loading
	// rendering another loadingOverlayComponent or overlayLoadingTemplate does not work
	loadingOverlayComponentParams: { loading: true },

Add filter by substation or VL to contingency list #741

Are you sure you want to change the base?

Add filter by substation or VL to contingency list #741

Uh oh!

Conversation

flomillot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EtienneLt commented Oct 13, 2025

Uh oh!

EtienneLt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

basseche Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

basseche Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thangqp Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

thangqp Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

thangqp Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flomillot commented Oct 10, 2025 •

edited

Loading