Skip to content

Implement SlaveId and Connector APIs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2018
Merged

Implement SlaveId and Connector APIs #8

merged 3 commits into from
Oct 18, 2018

Conversation

andig
Copy link
Contributor

@andig andig commented Oct 17, 2018

Migrated from goburrow/modbus#36

@gq0 gq0 self-requested a review October 18, 2018 15:32
gq0
gq0 approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@gq0 gq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gq0 gq0 merged commit 0902a7b into grid-x:master Oct 18, 2018
@sodabrew sodabrew mentioned this pull request Nov 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gq0 gq0 gq0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andig @gq0