Skip to content

fixes for Java specific items - #4

Open
darinpope wants to merge 2 commits into
greyshirtguy:masterfrom
darinpope:misc-java-items
Open

fixes for Java specific items#4
darinpope wants to merge 2 commits into
greyshirtguy:masterfrom
darinpope:misc-java-items

Conversation

@darinpope

Copy link
Copy Markdown

when doing protoc for Java, these were a few items that needed to be cleaned up:

proCore.proto:6:1: warning: Import action.proto is unused.
[libprotobuf WARNING google/protobuf/compiler/java/file.cc:235] dmxProfiles.proto: The file's outer class name, "DmxProfiles", matches the name of one of the types declared inside it when case is ignored. This can cause compilation issues on Windows / MacOS. Please either rename the type or use the java_outer_classname option to specify a different outer class name for the .proto file to be safe.
[libprotobuf WARNING google/protobuf/compiler/java/file.cc:235] keymapping.proto: The file's outer class name, "Keymapping", matches the name of one of the types declared inside it when case is ignored. This can cause compilation issues on Windows / MacOS. Please either rename the type or use the java_outer_classname option to specify a different outer class name for the .proto file to be safe.

when doing protoc for Java, these were a few items
that needed to be cleaned up
@greyshirtguy

Copy link
Copy Markdown
Owner

Sorry I've missed this for so long...
I'll need a bit of time to think how to best approach - as I have a bit of an automated process to generate the proto - and the next time I run it - it would loose your custom changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants