Skip to content

Change: Update Grammar exclusion regex. Add relevant test. #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n-thumann merged 1 commit into from
Dec 16, 2025
Merged

Change: Update Grammar exclusion regex. Add relevant test. #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/plugins/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,3 +453,24 @@ def test_grammar_fp3(self):
results = list(plugin.run())

self.assertEqual(len(results), 0)

def test_grammar_fp4(self):
nasl_file = Path(__file__).parent / "test.nasl"
content = (
' script_tag(name:"cvss_base", value:"4.0");\n'
' script_tag(name:"insight", value:"*snip*\n'
" control of a remote NFS server to create a setuid root "
"executable on\n the exported filesystem of the remote NFS "
"server. If this filesystem\n was mounted with the default "
'hosts map, it would allow the user to\n *snip*");\n'
' script_tag(name:"solution_type", value:"VendorFix");\n'
' script_tag(name:"solution", value:"meh");\n'
)
fake_context = self.create_file_plugin_context(
nasl_file=nasl_file, file_content=content
)
plugin = CheckGrammar(fake_context)

results = list(plugin.run())

self.assertEqual(len(results), 0)
8 changes: 6 additions & 2 deletions troubadix/plugins/grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,12 @@
# catch this wrongly...
# - Cases like "this filesystem" vs. "these filesystems" are also handled /
# excluded here
PatternCheck(r'this\s+(filesystem|allow\s+list)[\s.",]+', re.IGNORECASE),
PatternCheck(r'these\s+(filesystem|allow\s+list)s[\s.",]+', re.IGNORECASE),
PatternCheck(
r'this\s+(filesystem|allow\s+list)([\s.",]+|$)', re.IGNORECASE
),
PatternCheck(
r'these\s+(filesystem|allow\s+list)s([\s.",]+|$)', re.IGNORECASE
),
# Like seen in e.g. 2008/freebsd/freebsd_mod_php4-twig.nasl
PatternCheck(r'(\s+|")[Aa]\s+multiple\s+of'),
# WITH can be used like e.g. the following which is valid:
Expand Down
Loading