Declare handle_get_credentials variables where they are used

[mattmundell]

What

In handle_get_credentials move the declarations of variables public_key and private_key down to the blocks they are used in.

Why

This reduces the scope of the variables, making the code easier to understand.

There is some performance gain to be made when getting the credentials, but the situation is complex. Hoping small changes like this will make the gains achievable in the future.

Test

To test private_key:

$ o m m "<create_credential><name>usk: username and ssh private key</name><type>usk</type><login>username</login><key><phrase></phrase><private>$(cat ~/tmp/key/ed25519)</private></key></create_credential>"
$ o m m '<get_credentials credential_id="7fc16405-c190-4a5a-999b-bd31a055933f" details="1" format="key"/>'

To test public_key:

$ o m m "<create_credential><name>gpg</name><type>pgp</type><login>username</login><key><phrase>test</phrase><public>$(cat ~/tmp/key/gpg.pub)</public></key></create_credential>"
$ o m m '<get_credentials credential_id="85fda2a1-ba94-4f64-b9d8-33935f469ab4" details="1" format="key"/>'

References

/pull/2122 explores the potential performance gains.

[github-actions]

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.