Skip to content

Conversation

@mattmundell
Copy link
Contributor

What

Fix the build when openvasd is off and the other two are on.

Why

The http dir was being included multiple times.

Testing

Building with -D ENABLE_AGENTS=1 -D ENABLE_CREDENTIAL_STORES=1 -D ENABLE_CONTAINER_SCANNING=1 -D ENABLE_OPENVASD=0 before:

CMake Error at CMakeLists.txt:336 (add_subdirectory):
  The binary directory

    /path/to/build/gvm-libs/http

  is already used to build a source directory.  It cannot be used to build
  source directory

    /path/to/main/gvm-libs/http

  Specify a unique binary directory name.

Whereas after the PR it succeeds.

The http dir was being included multiple times.
@mattmundell mattmundell requested review from a team as code owners January 9, 2026 14:15
@greenbonebot greenbonebot enabled auto-merge (rebase) January 9, 2026 14:15
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2035c16.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot
Copy link
Member

Scan: 'CMakeLists.txt'

Nothing detected in CMakeLists.txt
Scan took 0.00 seconds

@greenbonebot greenbonebot merged commit 85f9f9b into main Jan 9, 2026
21 checks passed
@greenbonebot greenbonebot deleted the fix-add-http branch January 9, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants