Skip to content

Conversation

@ozgen
Copy link
Member

@ozgen ozgen commented Jan 8, 2026

What

Fixes a dashboard crash by always passing a valid render function to DataDisplay.

Why

DataDisplay expects children to be a function and fails when it is missing. This change prevents runtime errors in the dashboard.

References

GEA-1362

@ozgen ozgen requested a review from a team as a code owner January 8, 2026 13:52
@greenbonebot greenbonebot enabled auto-merge (rebase) January 8, 2026 13:52
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 16b0818.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.74%. Comparing base (871cacd) to head (16b0818).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/web/components/dashboard/display/DataDisplay.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5054      +/-   ##
==========================================
- Coverage   75.74%   75.74%   -0.01%     
==========================================
  Files        1137     1137              
  Lines       29666    29668       +2     
  Branches     8891     8893       +2     
==========================================
  Hits        22471    22471              
- Misses       6433     6435       +2     
  Partials      762      762              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greenbonebot greenbonebot merged commit eaa8e4d into main Jan 8, 2026
23 of 24 checks passed
@greenbonebot greenbonebot deleted the fix-datadisplay-children-renderprop branch January 8, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants