Skip to content

Conversation

@bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jan 9, 2026

What

Modernize the codebase

  • use ruff for linting and formatting
  • enable more linting rules
  • upgrade codebase for modern Python >= 3.10 syntax (for example PEP 585 and PEP604)
  • upgrade pyproject.toml for PEP 621 definitions
  • use up-to-date container image build workflow

Why

Maintenance of the Python project

Use a single tool for formatting and linting. ruff is just faster.
@bjoernricks bjoernricks requested review from a team as code owners January 9, 2026 12:52
@greenbonebot greenbonebot enabled auto-merge (rebase) January 9, 2026 12:52
@greenbonebot
Copy link
Member

greenbonebot commented Jan 9, 2026

Scanning the following files:

.github/workflows/ci-python.yml
.github/workflows/container.yml
README.md
greenbone/feed/sync/config.py
greenbone/feed/sync/errors.py
greenbone/feed/sync/helper.py
greenbone/feed/sync/main.py
greenbone/feed/sync/parser.py
greenbone/feed/sync/rsync.py
poetry.lock
pyproject.toml
tests/test_config.py
tests/test_rsync.py

Scan: '.github/workflows/ci-python.yml'

Nothing detected in .github/workflows/ci-python.yml
Scan took 0.00 seconds

Scan: '.github/workflows/container.yml'

Nothing detected in .github/workflows/container.yml
Scan took 0.00 seconds

Scan: 'README.md'

Nothing detected in README.md
Scan took 0.00 seconds

Scan: 'greenbone/feed/sync/config.py'

Nothing detected in greenbone/feed/sync/config.py
Scan took 0.00 seconds

Scan: 'greenbone/feed/sync/errors.py'

Nothing detected in greenbone/feed/sync/errors.py
Scan took 0.00 seconds

Scan: 'greenbone/feed/sync/helper.py'

Nothing detected in greenbone/feed/sync/helper.py
Scan took 0.00 seconds

Scan: 'greenbone/feed/sync/main.py'

Nothing detected in greenbone/feed/sync/main.py
Scan took 0.00 seconds

Scan: 'greenbone/feed/sync/parser.py'

Nothing detected in greenbone/feed/sync/parser.py
Scan took 0.00 seconds

Scan: 'greenbone/feed/sync/rsync.py'

Nothing detected in greenbone/feed/sync/rsync.py
Scan took 0.00 seconds

Scan: 'poetry.lock'

Nothing detected in poetry.lock
Scan took 0.01 seconds

Scan: 'pyproject.toml'

Nothing detected in pyproject.toml
Scan took 0.00 seconds

Scan: 'tests/test_config.py'

Nothing detected in tests/test_config.py
Scan took 0.00 seconds

Scan: 'tests/test_rsync.py'

Nothing detected in tests/test_rsync.py
Scan took 0.00 seconds

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.35%. Comparing base (6dd79b9) to head (f6bd108).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files           7        7           
  Lines         465      468    +3     
=======================================
+ Hits          462      465    +3     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

With PEP 621 the project specification got standardized and should be
used for being future proof. Also by using PEP 621 it is easier to
switch to another build tool.
Enable additional linting rules for ruff. Make the code more strict and
avoid problems.
Enable pyupgrade rules (see https://docs.astral.sh/ruff/rules/#pyupgrade-up
for details) and update code to more modern Python since we require
Python 3.10 now.
The newer workflow is easier to maintain and more flexible.
@greenbonebot greenbonebot merged commit 5fa99d5 into main Jan 9, 2026
26 checks passed
@greenbonebot greenbonebot deleted the update-tooling branch January 9, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants