-
Notifications
You must be signed in to change notification settings - Fork 12
Update Tooling #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tooling #327
Conversation
Use a single tool for formatting and linting. ruff is just faster.
Scanning the following files:
Scan: '.github/workflows/ci-python.yml'Nothing detected in .github/workflows/ci-python.yml Scan: '.github/workflows/container.yml'Nothing detected in .github/workflows/container.yml Scan: 'README.md'Nothing detected in README.md Scan: 'greenbone/feed/sync/config.py'Nothing detected in greenbone/feed/sync/config.py Scan: 'greenbone/feed/sync/errors.py'Nothing detected in greenbone/feed/sync/errors.py Scan: 'greenbone/feed/sync/helper.py'Nothing detected in greenbone/feed/sync/helper.py Scan: 'greenbone/feed/sync/main.py'Nothing detected in greenbone/feed/sync/main.py Scan: 'greenbone/feed/sync/parser.py'Nothing detected in greenbone/feed/sync/parser.py Scan: 'greenbone/feed/sync/rsync.py'Nothing detected in greenbone/feed/sync/rsync.py Scan: 'poetry.lock'Nothing detected in poetry.lock Scan: 'pyproject.toml'Nothing detected in pyproject.toml Scan: 'tests/test_config.py'Nothing detected in tests/test_config.py Scan: 'tests/test_rsync.py'Nothing detected in tests/test_rsync.py |
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 7 7
Lines 465 468 +3
=======================================
+ Hits 462 465 +3
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With PEP 621 the project specification got standardized and should be used for being future proof. Also by using PEP 621 it is easier to switch to another build tool.
Enable additional linting rules for ruff. Make the code more strict and avoid problems.
Enable pyupgrade rules (see https://docs.astral.sh/ruff/rules/#pyupgrade-up for details) and update code to more modern Python since we require Python 3.10 now.
The newer workflow is easier to maintain and more flexible.
8f3af0c to
f6bd108
Compare
What
Modernize the codebase
pyproject.tomlfor PEP 621 definitionsWhy
Maintenance of the Python project