lf_interop_throughput.py: LAN-3628 - Verify CX 'run' state prior to starting tests and improved flake8 compliance #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all flake8 complaints to make script compliant. A few noqa in line comments inserted that can be improved later. Verified still functional with: ./lf_interop_throughput.py --mgr 192.168.91.50 --mgr_port 8080 --ssid Quincefruit --passwd lanforge --security wpa2 --upstream_port 1.050.01 --traffic_type lf_udp --download 100000000 --test_duration 1m --packet_size 1500 --incremental_capacity 1 --precleanup --postcleanup Signed-off-by: Cameron LaPlante <[email protected]>
claplante-candela
force-pushed
the
incrementalTP
branch
from
a90b8ac to
3bbf3ce
Compare
Moved arg parsing to parse_args function, and added validation for required arguments (validate_args). Verified with: ./lf_interop_throughput.py --mgr 192.168.91.50 --mgr_port 8080 --ssid Quincefruit --passwd lanforge --security wpa2 --upstream_port 1.050.01 --traffic_type lf_udp --download 100000000 --test_duration 1m --packet_size 1500 --incremental_capacity 1 --precleanup --postcleanup Signed-off-by: Cameron LaPlante <[email protected]>
Added get_cx_states to validate 'Run' state before beginning specified test duration. Verified with: ./lf_interop_throughput.py --mgr 192.168.91.50 --mgr_port 8080 --ssid Quincefruit --passwd lanforge --security wpa2 --upstream_port 1.050.01 --traffic_type lf_udp --download 100000000 --test_duration 1m --packet_size 1500 --incremental_capacity 1 --precleanup --postcleanup Signed-off-by: Cameron LaPlante <[email protected]>
Adding some headers to functions, included 'r' in top header, general tidying. Verified with: ./lf_interop_throughput.py --mgr 192.168.91.50 --mgr_port 8080 --ssid Quincefruit --passwd lanforge --security wpa2 --upstream_port 1.050.01 --traffic_type lf_udp --download 100000000 --test_duration 1m --packet_size 1500 --incremental_capacity 1 --precleanup --postcleanup Signed-off-by: Cameron LaPlante <[email protected]>
claplante-candela
changed the title
claplante-candela
assigned
claplante-candela and
a-gavin and unassigned
claplante-candela
a-gavin
requested changes
Feb 4, 2025
There was a problem hiding this comment.
I would rather we use the required=True kwarg in the add_argument() function for each of the default arguments, instead of checking for them in argument validation.
Can you also check w/ CT-IN to verify adding this check doesn't break any assumptions their automation may make? I worry that introducing these checks may break existing WebGUI assumptions
val Added max_retries to cx states loop to avoid infinite checking if error occurs.i Removed validate args function and used kwarg required=True instead. Verified with: ./lf_interop_throughput.py --mgr 192.168.91.50 --mgr_port 8080 --ssid Quincefruit --passwd lanforge --security wpa2 --upstream_port 1.050.01 --traffic_type lf_udp --download 100000000 --test_duration 1m --packet_size 1500 --incremental_capacity 1 --precleanup --postcleanup Signed-off-by: Cameron LaPlante <[email protected]>
claplante-candela
force-pushed
the
incrementalTP
branch
from
d9c60d7 to
da14561
Compare
|
This PR is blocked pending upstreaming of CT-IN WebUI PR. |
|
CT-IN WebUI PR is in. Please address conflicts, thanks! @claplante-candela |
|
@claplante-candela I understand that you're working on other tasks right now, but just want to make sure this is on your radar. The "big push" to get CT-IN changes merged is complete, so no more blockers for this. As I understand it, this is fix is still desired CC: @goyalsaurabh06 |
smileyrekiere
approved these changes
Apr 22, 2025
smileyrekiere
approved these changes
Apr 22, 2025
smileyrekiere
approved these changes
Apr 22, 2025
smileyrekiere
requested changes
Apr 22, 2025
|
|
||
| required.add_argument('--device_list', help="Enter the devices on which the test should be run", default=[]) | ||
| required.add_argument('--mgr', '--lfmgr', help='hostname for where LANforge GUI is running') | ||
| required.add_argument('--mgr', '--lfmgr', help='hostname for where LANforge GUI is running', required=True) |
There was a problem hiding this comment.
This needs to be refactored as it will not work for help summary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected myriad of flake8 compliance issues.
Added cx state validation before running test duration to avoid logging zero throughput on test.
Improved clarity of required arguments by moving arg parsing and adding validation to exit gracefully.
Verified with:
./lf_interop_throughput.py --mgr 192.168.91.50 --mgr_port 8080 --ssid Quincefruit --passwd lanforge --security wpa2 --upstream_port 1.050.01 --traffic_type lf_udp --download 100000000 --test_duration 1m --packet_size 1500 --incremental_capacity 1 --precleanup --postcleanup
Signed-off-by: Cameron LaPlante [email protected]