Enhance Real Browser Test reporting, device mapping, and cleanup logic #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-gavin
requested changes
Oct 23, 2025
Collaborator
a-gavin
left a comment
a-gavin
left a comment
There was a problem hiding this comment.
Possibly I missed it, but I don't see any manual CLI used to verify the script changes for the lf_interop_real_browser.py test? If it's not present, please include it in the final commit message that modifies the script (linting commit).
Narayana-CT
force-pushed
the
real_browser_groups
branch
from
b670f3c to
1e6a9dd
Compare
Contributor
Author
|
Hi @a-gavin, added the verified CLI in the latest linting commit. Please let me know if you face any issues. Thank you. |
…ults by group Added a new method get_test_results_data to RealBrowserTest for retrieving test result subsets based on group membership. Signed-off-by: Narayana-CT <[email protected]>
Enhanced RealBrowserTest to retrieve Android device information from the /adb endpoint and map each user to its corresponding device serial number. Signed-off-by: Narayana-CT <[email protected]>
… moved to web UI Removed the webui_stop method and its call in main since test stop status is now managed directly from the web UI. This change simplifies backend logic and avoids redundant HTTP POST requests. Signed-off-by: Narayana-CT <[email protected]>
…ping users to serials Signed-off-by: Narayana-CT <[email protected]>
…tables in report Enhanced the create_report method to build separate test result tables for each selected group when both groups and profiles are present. Signed-off-by: Narayana-CT <[email protected]>
Removed code that automatically converted URLs starting with 'www.' or 'http://' to 'https://'. Signed-off-by: Narayana-CT <[email protected]>
Verified CLI: python3 lf_interop_real_browser_test.py --mgr 192.168.214.219 --url "https://google.com" --duration 1m --device_list 1.10,1.12 --debug --upstream_port 1.1.eth1 Signed-off-by: Narayana-CT <[email protected]>
Narayana-CT
force-pushed
the
real_browser_groups
branch
from
1e6a9dd to
24c3e69
Compare
a-gavin
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added group-specific result tables for clearer reporting.
Mapped user names to Android serial numbers via /adb for accurate pass/fail evaluation.
Removed deprecated webui_stop and redundant URL normalization logic.