Open
Conversation
if sell offer got updated during a running accept against an old sell offer, drop the reserved funds due to that accept when it expires discussed on: https://bitcointalk.org/index.php?topic=292628.msg5487346#msg5487346
it caused under certain conditions to a mismatch of accept and sell orders
show on btcpayment view
if accepts is alredy 100% paid, pay the next one example: http://masterchain.info/btcpayment.html?tx=5eea7fcad063871ece3404237fb2b5d66cf79b51e371c2f8aef6e7061aacd197¤cy=TMSC
examle transaction: 8fba98bc4ec872e8529433d70f1ac4f2724e0f42513214851b8155fa17522e3e where the input is a multisig address
Such a case may be caused by a bug, but in some cases it is a normal behavior the trigger for this change is: https://masterchain.info/selloffer.html?tx=b4fff0b33a547078cbde9a824a71a1d1ecdc6d234c0a2ac5df9123e129fa44a1¤cy=MSC Although transaction got parsed well, the automatic bug alert mechanism prevented the sell offer from being attached to the seller address, and therefore it was not available on the user interface, and the reserved funds did not get update. Any user could have accepted this sell offer if they visited the sell offer page directly.
if a transaction does not originate from exodus, do not allow multiple outputs to exodus example: https://masterchain.info/simplesend.html?tx=f1a0f43f10c3af7eff7b998ef0eb82f0eb82698f3752b27486e5537895207d51 has 2 outputs of 5460 satoshi to exodus
sync also html_includes to auto generate the updated html
Merge latest updates
… single block The mechanism that checks expiration of accept offers uses a dictionary for alarms which contains expration block number as a key and a list of accept txid that expire at that block. While iterating on the list, the code removed checked accept txid from that list In a case where multiple accept transactions expire in a single block, this removal causes the second accept expiration to be skipped. specifically, this unpaid accept offer was hanging in a non expired state: https://masterchain.info/sellaccept.html?tx=5737353a669583964a296ef920837fd97ad5c89c3dee9e8216e674dad5c76c6e¤cy=MSC avoiding the removal of old alerts from this dictionary fixes the problem This is the only case that such a problem has happened. The effect was a wrong calculation of the following accept offer (missing 1.3 MSC): https://masterchain.info/sellaccept.html?tx=d846fd98dcd268f835d272e13b8623fd2ca435060fa91baaf8426bffb067a5b1¤cy=MSC but since we could see that the later payment was correct, and the consensus support it, I see no problem to correct this problem retrospective. If the foundation insists, I could still keep the bug until current block.
bugfix: correct expiration of multiple accept offers that expire on a si...
…nto HEAD Conflicts: apps/sell.py html_includes/body_address.inc html_includes/body_btcpayment.inc html_includes/body_recent.inc html_includes/body_sellaccept.inc html_includes/body_selloffer.inc html_includes/body_simplesend.inc html_includes/head_begin.inc msc_validate.py www/404.html www/API.html www/About.html www/Address.html www/License.html www/acceptform.html www/btcpayment.html www/exodus.html www/index.html www/javascript_required.html www/professional.html www/sellaccept.html www/sellform.html www/selloffer.html www/sendform.html www/simplesend.html www/wallet.html
…ll, UI considerations and field error handling
check milliseconds for deadline
Make sure to truncate the tokens awarded to issuer individually
[1:17:26 PM] faiz: basically we 'forget' to release the reserved funds on running accepts IF the accept expires AND the sell offer is updated [1:18:12 PM] faiz: adding the release of funds for expired accepts gets that specific tx in line
Fix TMSC out of consensus case:
Add checks
Ensure 0 < property_type is invalid
Remove btc as valid CID desired
Critical to keep consensus with mastercore
Necessary to keep in line with Mastercore
Fix to appropriately accredit duplicate properties, ex. Test prop SP2147483707
Add proper fee parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.