Additional access marking #5049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highway=pedestrian should support restricted access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5024
Fixes #4998
Changes proposed in this pull request:
access=destination) onhighway=motorway/trunk/primary(currently onlyaccess=noshown)highway=pedestrianusing white as contrasting colour.Note that a tweak to
functions.sqlis needed to allowhighway=pedestrianto support "restricted" access marking.Test rendering:
"restricted" access on major highways is not expected to be valid tagging. The purpose of the PR is to highlight potentially incorrect tagging.
Illustrations are taken from a hacked legend rendering, with
access=destinationon all highways.Note that the increased "coverage" of access tags needs to be weighed against a 7% increase in lines of XML. This is a result of all the added combinations of road types / 3 SQL queries / 3 access types.