feat: compact mode #536
Merged
feat: compact mode #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
kkirik
force-pushed
the
feat/compact-mode-2
branch
from
cfa2e03 to
d30d255
Compare
- Add isCompactMode prop to AsideHeaderGeneralProps - Add isCompactMode to renderFooter callback data - Pass isCompactMode through PageLayout and PageLayoutAside - Add compact-mode CSS class modifier to layout
- Add ITEM_HEIGHT_COMPACT constant (28px) - Add --_--item-height CSS variable with compact mode override - Update getItemHeight and getGroupHeight utilities for isCompactMode - Apply compact height to menu items, footer items, logo - Pass isCompactMode to CompositeBar components
- Add ASIDE_HEADER_COMPACT_WIDTH_COMPACT_MODE constant - Add --gn-aside-header-min-width override for compact mode - Update PageLayout size calculation for compact mode - Update CompositeBar mouse event detection - Update Header divider width
- Add --_--item-margin-inline CSS variable - Override to 6px in compact mode (default 10px) - Apply to logo-container, menu-items, footer, action items
- Add compact border-radius variables (2px collapsed) - Add HEADER_DIVIDER_HEIGHT_COMPACT constant (22px) - Update header divider dimensions for compact mode - Override --gn-aside-header-item-expanded-radius in compact mode
- Document isCompactMode prop in README (EN/RU) - Add CompactMode Storybook story - Add isCompactMode prop to AsideHeaderShowcase
kkirik
force-pushed
the
feat/compact-mode-2
branch
from
3424792 to
71bf7b4
Compare
kkirik
force-pushed
the
feat/compact-mode-2
branch
from
8cd56ec to
f790efb
Compare
kkirik
requested review from
BlackPoretsky,
DarkGenius,
Lunory and
kendoow
as code owners
DarkGenius
reviewed
Jan 12, 2026
src/components/AsideHeader/components/AllPagesPanel/AllPagesPanel.module.scss
Outdated
Show resolved
Hide resolved
DarkGenius
reviewed
Jan 12, 2026
src/components/AsideHeader/components/CompositeBar/Item/Item.module.scss
Show resolved
Hide resolved
DarkGenius
reviewed
Jan 12, 2026
DarkGenius
reviewed
Jan 13, 2026
| $class: &; | ||
| --gn-aside-header-min-width: 56px; | ||
|
|
||
| --_--item-icon-background-size: 36px; |
Collaborator
There was a problem hiding this comment.
Why is this variable no longer needed?
Contributor
Author
There was a problem hiding this comment.
Because I use the --_--item-height instead
DarkGenius
reviewed
Jan 13, 2026
src/components/AsideHeader/components/CompositeBar/CompositeBar.module.scss
Outdated
Show resolved
Hide resolved
DarkGenius
reviewed
Jan 13, 2026
| overflow: auto; | ||
| flex: 1; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Why these styles were removed?
Contributor
Author
There was a problem hiding this comment.
Because they're unused
DarkGenius
reviewed
Jan 13, 2026
src/components/AsideHeader/__tests__/AsideHeader.visual.test.tsx
Outdated
Show resolved
Hide resolved
DarkGenius
reviewed
Jan 13, 2026
Collaborator
|
Shouldn't the |
DarkGenius
reviewed
Jan 13, 2026
DarkGenius
reviewed
Jan 13, 2026
Contributor
Author
Nope, Because in this panel in compact mode should be regular margin between elements. |
kkirik
force-pushed
the
feat/compact-mode-2
branch
from
38d603b to
95c1a63
Compare
DarkGenius
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.