Okta: Backend/type changes for Okta Integration enrolment improvements #51731
Conversation
kiosion
added
the
no-changelog
kiosion
force-pushed
the
maxim/new-okta-setup
branch
4 times, most recently
from
c1d9dea to
c34e938
Compare
kiosion
force-pushed
the
maxim/new-okta-setup
branch
from
c34e938 to
f2b7a4e
Compare
| @@ -32,6 +32,8 @@ import ( | |||
| const ( | |||
| // OIDCJWKWURI is the relative path where the OIDC IdP JWKS is located | |||
| OIDCJWKWURI = "/.well-known/jwks-oidc" | |||
| // OktaJWKSURI is the relative path where the Okta JWKS is located | |||
There was a problem hiding this comment.
lol, is OIDCJWKWURI is a typo? (has a W instead of a S)
There was a problem hiding this comment.
looks like it, I just didn't want to increase the scope of this Okta work further by updating it
| [key: string]: any; | ||
| }; | ||
|
|
||
| export type PluginNameToDetails = { | ||
| okta: PluginStatusOkta; | ||
| [key: string]: any; |
There was a problem hiding this comment.
do we need the [key: string]: any;?
There was a problem hiding this comment.
I added these for using w/ some pluginsService funcs, so specifying one of those names will result in the return being properly typed... Since the default for the Plugin type's Spec/Status fields with no generics provided is any I figured I'd just keep that the same. Could remove it though and be a bit stricter.
There was a problem hiding this comment.
+1 on removing here and above unless absolutely necessary.
| @@ -32,6 +32,8 @@ import ( | |||
| const ( | |||
| // OIDCJWKWURI is the relative path where the OIDC IdP JWKS is located | |||
| OIDCJWKWURI = "/.well-known/jwks-oidc" | |||
| // OktaJWKSURI is the relative path where the Okta JWKS is located | |||
| OktaJWKSURI = "/.well-known/jwks-okta" | |||
There was a problem hiding this comment.
nit: spell out what the URI refers to
| OktaJWKSURI = "/.well-known/jwks-okta" | |
| OktaJWKSWellknownURI = "/.well-known/jwks-okta" |
| getIntegrationStatusRoute( | ||
| type: PluginKind | IntegrationKind, | ||
| name: string, | ||
| page?: string |
There was a problem hiding this comment.
nit: from the PR description, I think we are referring to status page here correct?
| page?: string | |
| statusPage?: string |
| | PluginDatadogSpec | ||
| | PluginEmailSpec | ||
| | PluginMsTeamsSpec; | ||
| export type PluginNameToSpec = { |
| [key: string]: any; | ||
| }; | ||
|
|
||
| export type PluginNameToDetails = { |
| [key: string]: any; | ||
| }; | ||
|
|
||
| export type PluginNameToDetails = { | ||
| okta: PluginStatusOkta; | ||
| [key: string]: any; |
There was a problem hiding this comment.
+1 on removing here and above unless absolutely necessary.
| credentialsInfo?: CredentialsInfo; | ||
| }; | ||
|
|
||
| export type CredentialsInfo = { |
There was a problem hiding this comment.
Can all fields be true at the same time?
JSDoc please.
Add types and update integration status page + enrol paths for Okta Integration enrolment changes. Required for #5994.