[Web] Remove local notifications #51624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
gzdunek
approved these changes
Jan 30, 2025
ravicious
approved these changes
Jan 30, 2025
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
rudream
force-pushed
the
yassine/access-list-reminders
branch
from
ab213d3 to
2a11012
Compare
rudream
force-pushed
the
yassine/remove-local-notifications
branch
from
96c5f5b to
fd1fb4a
Compare
rudream
added a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ecounterpart: https://github.com/gravitational/teleport.e/pull/5975This PR removes local notifications. This logic existed as a workaround due to a limitation in the notifications system not being able to prevent duplicate notifications. This limitation has been resolved and access list notifications (which this was being used for) will be generated using the native notifications system once #51581 is merged.