Upgrade vite to 6.0.11 #51356
Merged
Upgrade vite to 6.0.11 #51356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
added
the
no-changelog
ryanclark
approved these changes
Jan 22, 2025
flyinghermit
approved these changes
Jan 22, 2025
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
|
Waiting for gravitational/shared-workflows#310 before I can merge |
ravicious
reviewed
Jan 22, 2025
web/packages/build/vite/config.ts
Outdated
| @@ -57,6 +57,7 @@ export function createViteConfig( | |||
| const config: UserConfig = { | |||
| clearScreen: false, | |||
| server: { | |||
| allowedHosts: true, | |||
There was a problem hiding this comment.
I wonder if we could use the target variable instead of allowing all hosts?
I confirmed that HMR doesn't work when I comment out allowedHosts completely and that it still works with this solution in place.
diff --git a/web/packages/build/vite/config.ts b/web/packages/build/vite/config.ts
index e2e9db9f1d..9521631ddf 100644
--- a/web/packages/build/vite/config.ts
+++ b/web/packages/build/vite/config.ts
@@ -54,10 +54,15 @@ export function createViteConfig(
}
}
+ const targetHostname =
+ target !== DEFAULT_PROXY_TARGET
+ ? new URL(`http://${target}`).hostname
+ : undefined;
+
const config: UserConfig = {
clearScreen: false,
server: {
- allowedHosts: true,
+ allowedHosts: targetHostname ? [`.${targetHostname}`] : [],
fs: {
allow: [rootDirectory, '.'],
},
There was a problem hiding this comment.
patch works for me, i appreciate the improvement. applied
|
Vite was updated to v6 quite recently actually. We made the decision to update it to v6 without waiting for electron-vite. #50617 (review) |
This will upgrade vite. I'm getting an "unmet dep" warning for electron-vite saying it expects a max of vite 5, however we are currently on the latest version of electron-vite so I don't think there is much we can do here. We have already been running vite 6+ for months now tho and electron-vite has been working fine so I think its ok to ignore for now.
|
BTW, I just got a notification an hour ago under an electron-vite issue that the beta of v3 is out which updates Vite compatibility to v6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will upgrade vite. I'm getting an "unmet dep" warning for electron-vite saying it expects a max of vite 5, however we are currently on the latest version of electron-vite so I don't think there is much we can do here. We have already been running vite 6+ for months now tho and electron-vite has been working fine so I think its ok to ignore for now.
@ryanclark , i didn't have any issues with
localhostand my non-localhost domain that I typically run so I didn't need to updateallowedHosts, can you confirm?edit: confirmed we had a few users whos HMR didnt work without
allowedHostsso Ive updated it