Define Backend.GetRange to be inclusive
#50996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
the
no-changelog
espadolini
changed the title
Backend.GetRange being inclusiveBackend.GetRange to be inclusive
rosstimothy
approved these changes
Jan 13, 2025
gabrielcorado
approved these changes
Jan 14, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
|
@espadolini See the table below for backport results.
|
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Test for Backend.GetRange being inclusive * Get rid of the unused prefixItem * Fix memorybk GetRange not being inclusive * Fix etcdbk GetRange not being inclusive * Document the desired behavior of GetRange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of memorybk and etcdbk's
GetRangeoperation to match the behavior of the other backend drivers'GetRange, returning the item at the end of the range (if any is present, which in practice there won't be - which is also the reason why this change is effectively a no-op with the current Teleport code, as all current uses ofGetRangeinvolve reading up to the end of a prefix).