Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused NewIdentityServiceV2 #50991

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e
Submodule e updated from 65fa47 to 6831bf
2 changes: 1 addition & 1 deletion lib/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func NewServer(cfg *InitConfig, opts ...ServerOption) (*Server, error) {
cfg.Provisioner = local.NewProvisioningService(cfg.Backend)
}
if cfg.Identity == nil {
cfg.Identity, err = local.NewIdentityServiceV2(cfg.Backend)
cfg.Identity, err = local.NewIdentityService(cfg.Backend)
if err != nil {
return nil, trace.Wrap(err)
}
Expand Down
2 changes: 1 addition & 1 deletion lib/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ func New(config Config) (*Cache, error) {
return nil, trace.Wrap(err)
}

identityService, err := local.NewIdentityServiceV2(config.Backend)
identityService, err := local.NewIdentityService(config.Backend)
if err != nil {
cancel()
return nil, trace.Wrap(err)
Expand Down
2 changes: 1 addition & 1 deletion lib/services/local/headlessauthn_watcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func NewHeadlessAuthenticationWatcher(ctx context.Context, cfg HeadlessAuthentic
return nil, trace.Wrap(err)
}

identityService, err := NewIdentityServiceV2(cfg.Backend)
identityService, err := NewIdentityService(cfg.Backend)
if err != nil {
return nil, trace.Wrap(err)
}
Expand Down
8 changes: 1 addition & 7 deletions lib/services/local/users.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,6 @@ type IdentityService struct {
notificationsSvc *NotificationsService
}

// TODO(tross): DELETE ONCE e is updated to use NewIdentityService
// NewIdentityServiceV2 returns a new instance of IdentityService object
func NewIdentityServiceV2(backend backend.Backend) (*IdentityService, error) {
return NewIdentityService(backend)
}

// NewIdentityService returns a new instance of IdentityService object
func NewIdentityService(backend backend.Backend) (*IdentityService, error) {
notificationsSvc, err := NewNotificationsService(backend, backend.Clock())
Expand All @@ -100,7 +94,7 @@ func NewTestIdentityService(backend backend.Backend) (*IdentityService, error) {
panic("Attempted to create a test identity service outside of a test")
}

s, err := NewIdentityServiceV2(backend)
s, err := NewIdentityService(backend)
if err != nil {
return nil, trace.Wrap(err)
}
Expand Down
2 changes: 1 addition & 1 deletion lib/services/local/users_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ func TestNotificationCleanupOnUserDelete(t *testing.T) {
})
require.NoError(t, err)

identitySvc, err := local.NewIdentityServiceV2(backend)
identitySvc, err := local.NewIdentityService(backend)
require.NoError(t, err)
notificationsSvc, err := local.NewNotificationsService(backend, backend.Clock())
require.NoError(t, err)
Expand Down
Loading