Fix AWS SigV4 parsing #50973
Merged
Fix AWS SigV4 parsing #50973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing the AWS SigV4 Authorization header no longer requires spaces between the components - only the comma delimiter is required.
GavinFrazar
requested review from
greedy52
and removed request for
creack and
timothyb89
GavinFrazar
commented
Jan 13, 2025
greedy52
reviewed
Jan 13, 2025
greedy52
approved these changes
Jan 13, 2025
smallinsky
approved these changes
Jan 14, 2025
|
@GavinFrazar See the table below for backport results.
|
GavinFrazar
added a commit
that referenced
this pull request
Jan 14, 2025
* Fix AWS SigV4 parsing Parsing the AWS SigV4 Authorization header no longer requires spaces between the components - only the comma delimiter is required. * add test case for empty signed header list
GavinFrazar
added a commit
that referenced
this pull request
Jan 14, 2025
* Fix AWS SigV4 parsing Parsing the AWS SigV4 Authorization header no longer requires spaces between the components - only the comma delimiter is required. * add test case for empty signed header list
This was referenced Jan 14, 2025
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Fix AWS SigV4 parsing Parsing the AWS SigV4 Authorization header no longer requires spaces between the components - only the comma delimiter is required. * add test case for empty signed header list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50866
Changelog: Fixed AWS SigV4 parse errors in app access when the application omits the optional spaces between the SigV4 components.