Workload ID: Introduce basic rule condition operators #50940
Merged
+1,317
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
|
Amplify deployment status
|
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
force-pushed
the
strideynet/use-oneof-for-rule-conditions-workload-id
branch
from
f4e9b4b to
c7e5c7b
Compare
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
added
backport/branch/v16
backport/branch/v17
no-changelog
strideynet
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
strideynet
changed the title
github-actions
bot
requested review from
bernardjkim,
hugoShaka and
marcoandredinis
github-actions
bot
requested review from
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
tigrato
approved these changes
Jan 10, 2025
ptgott
approved these changes
Jan 10, 2025
public-teleport-github-review-bot
bot
removed request for
bernardjkim,
hugoShaka,
mmcallister,
r0mant,
xinding33,
zmb3 and
timothyb89
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Pull condition operators into a one of * Add wrapper structs to support repeated * Adjust for new protos * Fix tflint * Start fixing tests * Add more test cases * More test cases * Fix marshalling of resource * Fix test in lib/services
strideynet
deleted the
strideynet/use-oneof-for-rule-conditions-workload-id
branch
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Jan 13, 2025
* Pull condition operators into a one of * Add wrapper structs to support repeated * Adjust for new protos * Fix tflint * Start fixing tests * Add more test cases * More test cases * Fix marshalling of resource * Fix test in lib/services
strideynet
added a commit
that referenced
this pull request
Jan 13, 2025
* Pull condition operators into a one of * Add wrapper structs to support repeated * Adjust for new protos * Fix tflint * Start fixing tests * Add more test cases * More test cases * Fix marshalling of resource * Fix test in lib/services
This was referenced Jan 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
…50979) * Workload ID: Introduce basic rule condition operators (#50940) * Pull condition operators into a one of * Add wrapper structs to support repeated * Adjust for new protos * Fix tflint * Start fixing tests * Add more test cases * More test cases * Fix marshalling of resource * Fix test in lib/services * Backport hugo's changes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
…50978) * Workload ID: Introduce basic rule condition operators (#50940) * Pull condition operators into a one of * Add wrapper structs to support repeated * Adjust for new protos * Fix tflint * Start fixing tests * Add more test cases * More test cases * Fix marshalling of resource * Fix test in lib/services * Backport hugo's changes
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…50940) * Pull condition operators into a one of * Add wrapper structs to support repeated * Adjust for new protos * Fix tflint * Start fixing tests * Add more test cases * More test cases * Fix marshalling of resource * Fix test in lib/services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44006
Following gravitational/protoc-gen-terraform#47 - we can now use oneof in RFD153 resources and still generate a Terraform resource.
Moving a single field into a protobuf oneof should hypothetically be non-breaking - https://protobuf.dev/programming-guides/proto3/#backward