Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Add redirects based on 404s #50920

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Jan 9, 2025

Closes #48417

Add a redirect for any docs path that has returned at least 5 404 responses over the last 30 days.

Ignore 404s with destinations that are version-specific docs paths, e.g., /docs/ver/15.x/, since (a) our redirect system does not support these and (b) Teleport-owned sites do not include docs versions when they link to or mention docs URL paths.

@ptgott ptgott added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
paul.gottschling/2025-01-09-redirects 0b13ea3 4 ✅SUCCEED paul-gottschling-2025-01-09-redirects 2025-01-17 19:40:23

@ptgott ptgott force-pushed the paul.gottschling/2025-01-09-redirects branch from 85a033a to 2008223 Compare January 9, 2025 20:15
@ptgott ptgott linked an issue Jan 10, 2025 that may be closed by this pull request
@ptgott ptgott force-pushed the paul.gottschling/2025-01-09-redirects branch from 2008223 to 0d4c129 Compare January 14, 2025 20:27
@ptgott
Copy link
Contributor Author

ptgott commented Jan 15, 2025

@mmcallister Would you have time to take a look at this one? Thanks!

Add a redirect for any docs path that has returned at least 5 404
responses over the last 30 days.

Ignore 404s with destinations that are version-specific docs paths,
e.g., `/docs/ver/15.x/`, since (a) our redirect system does not support
these and (b) Teleport-owned sites do not include docs versions when
they link to or mention docs URL paths.
@ptgott ptgott force-pushed the paul.gottschling/2025-01-09-redirects branch from 0d4c129 to 0b13ea3 Compare January 17, 2025 19:33
@mmcallister mmcallister added this pull request to the merge queue Jan 21, 2025
Merged via the queue into branch/v17 with commit b2becb0 Jan 21, 2025
40 checks passed
@mmcallister mmcallister deleted the paul.gottschling/2025-01-09-redirects branch January 21, 2025 19:27
@public-teleport-github-review-bot

@ptgott See the table below for backport results.

Branch Result
branch/v16 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: fix 404 pages tracked in PostHog
3 participants