[v17] Add initial expiry service #50775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
capnspacehook,
fspmarshall and
r0mant
github-actions
bot
added
audit-log
EdwardDowling
force-pushed
the
edwarddowling/backport-49267/v17
branch
from
e089631 to
58a8843
Compare
EdwardDowling
force-pushed
the
edwarddowling/backport-49267/v17
branch
from
58a8843 to
ddf781c
Compare
r0mant
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
@EdwardDowling This is a non-trivial size backport - did you test it on v17 to make sure things still work as expected?
capnspacehook
approved these changes
Jan 14, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
Have confirmed the v17 version properly expires requests created via tsh and the web ui. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #49267
Addresses #47945
Adds a periodic check to ensure expired access requests are expired explicitly and emits an audit event when marking them as expired.
changelog: Emit audit events on access request expiry