Adding the Azure sync module functions along with new cloud client functionality #50366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
changed the base branch from
master
to
mvbrock/azure-integration-disco-proto
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
a817501 to
e88e148
Compare
Base automatically changed from
mvbrock/azure-integration-disco-proto
to
master
December 18, 2024 20:24
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
e88e148 to
308bc2c
Compare
mvbrock
added
the
no-changelog
tigrato
reviewed
Dec 19, 2024
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
02bcb5e to
0a4c1f4
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
0a4c1f4 to
672ae8d
Compare
|
🤖 Vercel preview here: https://docs-hx7av502y-goteleport.vercel.app/docs |
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
2894408 to
0dc6820
Compare
mvbrock
commented
Dec 30, 2024
zmb3
reviewed
Dec 30, 2024
tigrato
reviewed
Jan 2, 2025
tigrato
reviewed
Jan 2, 2025
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
932b2e8 to
a20ac6f
Compare
Co-authored-by: Tiago Silva <[email protected]>
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
8914c7d to
8b3cd5d
Compare
tigrato
approved these changes
Jan 13, 2025
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
7 tasks
mvbrock
added a commit
that referenced
this pull request
Jan 31, 2025
…nctionality (#50366) * Protobuf and configuration for Access Graph Azure Discovery * Adding the Azure sync module functions along with new cloud client functionality * Forgot to decouple role definitions fetching function from the fetcher * Moving reconciliation to the upstream azure sync PR * Moving reconciliation test to the upstream azure sync PR * Updating go.sum * Fixing rebase after protobuf gen * Nolinting until upstream PRs * Updating to use existing msgraph client * Adding protection around nil values * PR feedback * Updating principal fetching to incorporate metadata from principal subtypes * Updating opts to not leak URL parameters * Conformant package name * Using variadic options * PR feedback * Removing memberOf expansion * Expanding memberships by calling memberOf on each user * Also returning expanded principals for improved readability * Removing ptrToList * PR feedback * Rebase go.sum stuff * Go mod tidy * Linting * Linting * Collecting errors from fetching memberships and using a WithContext error group * Fixing go.mod * Update lib/msgraph/paginated.go Co-authored-by: Tiago Silva <[email protected]> * PR feedback * e ref update * e ref update * Fixing method * Fetching group members from groups rather than memberships of each principal * Linting --------- Co-authored-by: Tiago Silva <[email protected]>
8 tasks
mvbrock
added a commit
that referenced
this pull request
Jan 31, 2025
…nctionality (#50366) * Protobuf and configuration for Access Graph Azure Discovery * Adding the Azure sync module functions along with new cloud client functionality * Forgot to decouple role definitions fetching function from the fetcher * Moving reconciliation to the upstream azure sync PR * Moving reconciliation test to the upstream azure sync PR * Updating go.sum * Fixing rebase after protobuf gen * Nolinting until upstream PRs * Updating to use existing msgraph client * Adding protection around nil values * PR feedback * Updating principal fetching to incorporate metadata from principal subtypes * Updating opts to not leak URL parameters * Conformant package name * Using variadic options * PR feedback * Removing memberOf expansion * Expanding memberships by calling memberOf on each user * Also returning expanded principals for improved readability * Removing ptrToList * PR feedback * Rebase go.sum stuff * Go mod tidy * Linting * Linting * Collecting errors from fetching memberships and using a WithContext error group * Fixing go.mod * Update lib/msgraph/paginated.go Co-authored-by: Tiago Silva <[email protected]> * PR feedback * e ref update * e ref update * Fixing method * Fetching group members from groups rather than memberships of each principal * Linting --------- Co-authored-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of splitting #48843 into smaller PRs, and provides the Azure fetching functions and new cloud client functionality specifically for role assignments and definitions. This PR also incorporates the existing lib/msgraph client and removes the extraneous client code from the original PR.