Add the decisionv1.Service boilerplate #49912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
the
no-changelog
|
Branched from #49875. |
|
Friendly ping @rosstimothy @fspmarshall. |
codingllama
force-pushed
the
codingllama/pdp-skeleton
branch
from
6ff4847 to
0fb1117
Compare
|
Friendly ping reviewers? The base has landed so this is now free to be merged as well (pending review, ofc). |
rosstimothy
approved these changes
Dec 16, 2024
strideynet
approved these changes
Dec 17, 2024
public-teleport-github-review-bot
bot
removed request for
kopiczko and
fspmarshall
|
FYI @fspmarshall I'll go ahead and merge this. If you have comments let me know and I'll address them in a follow up. |
23 tasks
fspmarshall
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing
fspmarshall
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing
fspmarshall
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing
This was referenced Jan 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Add initial Decision (aka PDP) protos (#49875) * Clone protos from fspmarshall/pdp-work-02 * Use decisionpb as the Go package alias * Update DecisionService docs * Split identity protos into separate files * Update Metadata docs * Split metadata into separate files * Update Resource docs * Update database access docs and fields * Update SSH access docs and fields * Ignore breaking changes on decision protos * Update generated protos * Use teleport.trait.v1.Trait * Document mutual dependency between "ResourceID" types * nit: s/ResourceID/ResourceId * nit: Use the correct CamelCase field name in comments * Update generated protos * Add RouteToApp.target_port * Update generated protos * Update comments on TLSIdentity / tlsca.Identity * Update generated protos * Add the decisionv1.Service boilerplate (#49912) * Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing * Add conversions to/from decisionpb.TLSIdentity (#50308) * Add conversions to/from decisionpb.TLSIdentity * Map timestamppb.Timestamp{} to 0-0-0 0:0.0 (instead of unix epoch) * Document that slices are not deep-copied * Add EvaluateDatabaseAccessRequest.database (#50481) * Add EvaluateDatabaseAccessRequest.database * Update generated protos * fix protos & tls identity --------- Co-authored-by: Alan Parra <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Add initial Decision (aka PDP) protos (#49875) * Clone protos from fspmarshall/pdp-work-02 * Use decisionpb as the Go package alias * Update DecisionService docs * Split identity protos into separate files * Update Metadata docs * Split metadata into separate files * Update Resource docs * Update database access docs and fields * Update SSH access docs and fields * Ignore breaking changes on decision protos * Update generated protos * Use teleport.trait.v1.Trait * Document mutual dependency between "ResourceID" types * nit: s/ResourceID/ResourceId * nit: Use the correct CamelCase field name in comments * Update generated protos * Add RouteToApp.target_port * Update generated protos * Update comments on TLSIdentity / tlsca.Identity * Update generated protos * Add the decisionv1.Service boilerplate (#49912) * Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing * Add conversions to/from decisionpb.TLSIdentity (#50308) * Add conversions to/from decisionpb.TLSIdentity * Map timestamppb.Timestamp{} to 0-0-0 0:0.0 (instead of unix epoch) * Document that slices are not deep-copied * Add EvaluateDatabaseAccessRequest.database (#50481) * Add EvaluateDatabaseAccessRequest.database * Update generated protos * fix protos & tls identity --------- Co-authored-by: Alan Parra <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Add initial Decision (aka PDP) protos (#49875) * Clone protos from fspmarshall/pdp-work-02 * Use decisionpb as the Go package alias * Update DecisionService docs * Split identity protos into separate files * Update Metadata docs * Split metadata into separate files * Update Resource docs * Update database access docs and fields * Update SSH access docs and fields * Ignore breaking changes on decision protos * Update generated protos * Use teleport.trait.v1.Trait * Document mutual dependency between "ResourceID" types * nit: s/ResourceID/ResourceId * nit: Use the correct CamelCase field name in comments * Update generated protos * Add RouteToApp.target_port * Update generated protos * Update comments on TLSIdentity / tlsca.Identity * Update generated protos * Add the decisionv1.Service boilerplate (#49912) * Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing * Add conversions to/from decisionpb.TLSIdentity (#50308) * Add conversions to/from decisionpb.TLSIdentity * Map timestamppb.Timestamp{} to 0-0-0 0:0.0 (instead of unix epoch) * Document that slices are not deep-copied * Add EvaluateDatabaseAccessRequest.database (#50481) * Add EvaluateDatabaseAccessRequest.database * Update generated protos --------- Co-authored-by: Alan Parra <[email protected]>
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the gRPC boilerplate, wires service and client and adds a simple test.
#49837