Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub proxy part 5: OAuth flow to retrieve GitHub identity #49849

Merged
merged 6 commits into from
Dec 10, 2024
Merged

GitHub proxy part 5: OAuth flow to retrieve GitHub identity #49849

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ab9743
GitHub proxy part 5: OAuth flow to retrieve GitHub identity
greedy52 Dec 5, 2024
b5d38f5
review comments round1
greedy52 Dec 9, 2024
c20d7ef
review comments round 2 and update tsh git list
greedy52 Dec 10, 2024
7fc3873
make -C integrations/operator crd
greedy52 Dec 10, 2024
7f9eaf2
make -C integrations/terraform docs
greedy52 Dec 10, 2024
e1703d8
fix flaky test
greedy52 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix flaky test
  • Loading branch information
@greedy52
greedy52 committed Dec 10, 2024
commit e1703d81d8ca415d27263d2fc4338ceee43efe58
5 changes: 3 additions & 2 deletions lib/client/client_store_test.go
View file
Original file line number Diff line number Diff line change
@@ -61,11 +61,12 @@ func newTestAuthority(t *testing.T) testAuthority {
tlsCA, trustedCerts, err := newSelfSignedCA(CAPriv, "localhost")
require.NoError(t, err)

clock := clockwork.NewFakeClock()
return testAuthority{
keygen: testauthority.New(),
keygen: testauthority.NewWithClock(clock),
tlsCA: tlsCA,
trustedCerts: trustedCerts,
clock: clockwork.NewFakeClock(),
clock: clock,
}
}